-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexp crash on ppc64le #44055
Labels
v8 engine
Issues and PRs related to the V8 dependency.
Comments
Cc @nodejs/platform-ppc |
Thanks for reporting this issue, this patch should resolve it https://chromium-review.googlesource.com/c/v8/v8/+/3797832, |
I recompiled node 18.6 with the patch and it doesn't crash anymore. |
Also the test-ci-js suite pass. |
Glad to hear that, thanks for running the tests. |
danielleadams
pushed a commit
that referenced
this issue
Aug 16, 2022
Original commit message: PPC: pass a scratch reg when using register_location Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82146} Fixes: #44055 PR-URL: #44115 Refs: v8/v8@9861ce1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno
pushed a commit
that referenced
this issue
Aug 23, 2022
Original commit message: PPC: pass a scratch reg when using register_location Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82146} Fixes: #44055 PR-URL: #44115 Refs: v8/v8@9861ce1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this issue
Sep 15, 2022
Original commit message: PPC: pass a scratch reg when using register_location Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82146} Fixes: nodejs#44055 PR-URL: nodejs#44115 Refs: v8/v8@9861ce1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v18.7.0
Platform
Linux plummer 5.10.0-16-powerpc64le #1 SMP Debian 5.10.127-2 (2022-07-23) ppc64le GNU/Linux
Subsystem
v8 regexp
What steps will reproduce the bug?
Run the attached file which contains a very long regexp.
crash_irregexp_ppc64el.js.txt
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
No crash, as on the other architectures.
What do you see instead?
Additional information
It seems upstream v8 has fixed a similar bug not so long ago (their fix is already in nodejs), maybe they overlooked something:
v8/v8@9227a8d
Architecture: ppc64le
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Model name: POWER8 (architected), altivec supported
Model: 2.1 (pvr 004b 0201)
The text was updated successfully, but these errors were encountered: