Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"node:" prefix #45001

Closed
meku opened this issue Oct 14, 2022 · 1 comment · Fixed by #45147
Closed

"node:" prefix #45001

meku opened this issue Oct 14, 2022 · 1 comment · Fixed by #45147

Comments

@meku
Copy link

meku commented Oct 14, 2022

node/lib/internal/modules/cjs/loader.js

Line 714 in 37e5152

Module._resolveLookupPaths = function(request, parent) {

Since the function does not check the built-in module "node:" prefix, unnecessary operations occur. It will directly return "null" if changed as follows;
( StringPrototypeStartsWith(request, 'node:') && BuiltinModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5)) ) || ( BuiltinModule.canBeRequiredByUsers(request) && BuiltinModule.canBeRequiredWithoutScheme(request) )
@meku meku closed this as completed Oct 14, 2022
@meku meku reopened this Oct 14, 2022
@meku
Copy link
Author

meku commented Oct 15, 2022

This confirms an incorrect result as follows:
console.log(require.resolve.paths("node:url"));
result:
[ 'G:\\www\\nodejs\\node_modules', 'G:\\www\\node_modules', 'G:\\node_modules']

fossamagna added a commit to fossamagna/node that referenced this issue Oct 24, 2022
@fossamagna
module: require.resolve.paths returns null with node schema
96f14e2 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: nodejs#45001
@fossamagna fossamagna mentioned this issue Oct 24, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Nov 20, 2022
@fossamagna
module: require.resolve.paths returns null with node schema
b8bc843 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this issue Nov 21, 2022
@fossamagna @ruyadorno
module: require.resolve.paths returns null with node schema
6fdd202 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this issue Nov 23, 2022
@fossamagna @marco-ippolito
module: require.resolve.paths returns null with node schema
851e784 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: nodejs#45001
PR-URL: nodejs#45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@fossamagna @danielleadams
module: require.resolve.paths returns null with node schema
80f063d 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@fossamagna @danielleadams
module: require.resolve.paths returns null with node schema
2fcd362 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@fossamagna @danielleadams
module: require.resolve.paths returns null with node schema
3197b91 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
@fossamagna @danielleadams
module: require.resolve.paths returns null with node schema
04bae26 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this issue Jan 5, 2023
@fossamagna @danielleadams
module: require.resolve.paths returns null with node schema
f6a0014 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
BethGriggs pushed a commit that referenced this issue Mar 27, 2023
@fossamagna @BethGriggs
module: require.resolve.paths returns null with node schema
809371a 
require.resolve.paths should returns null with builtin module.
when builtin module without `node:` schema, `paths` returns null.
But, it don't return null when builtin module with `node:` schema.

Fixes: #45001
PR-URL: #45147
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: require.resolve.paths returns null with node schema fossamagna/node
1 participant
@meku