Memory corruption and crash when streaming to zlib #45268

MaddieLowe · 2022-11-01T17:10:34Z

Version

v19.0.0

Platform

Linux 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

The bug happens when I send certain data in random-sized chunks over a socket and then pipe it to gzip. I tried to reproduce it with a smaller data sample, but unfortunately it seems that very specific data is needed to reproduce this bug. The script and data to reproduce the issue are here: https://github.com/morpheus-med/node-defect. Repro steps are:

Clone the repo https://github.com/morpheus-med/node-defect
Run unzip anonymized-data.zip
Run node index.js

How often does it reproduce? Is there a required condition?

It should crash in 1-2 runs. It crashes every time for me.

What is the expected behavior?

The expected behaviour is for the program to read and pipe the data to gzip without crashing.

What do you see instead?

The program crashes with:

double free or corruption (!prev)
Aborted (core dumped)
or
node: malloc.c:4036: _int_malloc: Assertion (unsigned long) (size) >= (unsigned long) (nb)' failed.
Aborted (core dumped)
or
corrupted size vs. prev_size
Aborted (core dumped)

Additional information

The application this is currently affecting is used for streaming medical imaging data to a viewer. We've currently got around the problem by downgrading node, but we would like to be able to upgrade node in the future to keep up with security updates.

The problem isn't reproducible with node 12.16.3, but is reproducible with versions 12.17.0 and later. I've done a git bisect and it seems to have been introduced with this commit: 9e33f97

Thanks for your help

The text was updated successfully, but these errors were encountered:

lpinca · 2022-11-01T19:54:38Z

I can reproduce on Node.js main but it seems to be fixed by #44412.

lpinca · 2022-11-16T20:16:20Z

I can no longer reproduce the issue with Node.js 19.1.0. Can you please confirm?

We also landed #45387 (not included in a release yet) and I also cannot reproduce the issue with Node.js main.

lpinca · 2022-11-17T13:08:48Z

I can no longer reproduce the issue with Node.js 19.1.0. Can you please confirm?

We also landed #45387 (not included in a release yet) and I also cannot reproduce the issue with Node.js main.

Scratch that. I can reproduce with both Node.js 19.1.0 and Node.js main on Linux.

lpinca · 2022-11-20T06:34:46Z

This patch seems to fix the issue

diff --git a/deps/zlib/zlib.gyp b/deps/zlib/zlib.gyp
index 547143e19d..50c8ae8be4 100644
--- a/deps/zlib/zlib.gyp
+++ b/deps/zlib/zlib.gyp
@@ -82,7 +82,6 @@
               'defines': [
                 'ADLER32_SIMD_SSSE3',
                 'INFLATE_CHUNK_SIMD_SSE2',
-                'CRC32_SIMD_SSE42_PCLMUL',
                 'DEFLATE_SLIDE_HASH_SSE2'
               ],
               'sources': [

but I' not sure if the issue is Node.js or in the zlib fork we use.

ywave620 · 2022-12-16T12:49:20Z

I can not reproduce it in v20.0.0-pre and v16.14.1. Are you still suffering from this issue? @MaddieLowe

lpinca · 2022-12-16T12:54:09Z

@ywave620 I can still reproduce with Node.js main.

ywave620 · 2022-12-17T09:02:02Z

Then it's weird🤔️, I ran the script with the main version of Node in Linux VM-79-215-centos 3.10.107-1-tlinux2_kvm_guest-0049 #1 SMP Tue Jul 30 23:46:29 CST 2019 x86_64 x86_64 x86_64 GNU/Linux multiple times, but I didn't find any crash.

lpinca · 2022-12-17T20:26:09Z

I can reproduce on every run on WSL and sometimes on macOS (13.1). I've also received this from a failed assertion in a recent run

/Users/luigi/code/node/node[1577]: ../src/node_zlib.cc:270:virtual node::(anonymous namespace)::CompressionStream<node::(anonymous namespace)::ZlibContext>::~CompressionStream() [CompressionContext = node::(anonymous namespace)::ZlibContext]: Assertion `(zlib_memory_) == (0)' failed.
 1: 0x10c6b9645 node::Abort() [/Users/luigi/code/node/out/Release/node]
 2: 0x10c6b9451 node::Assert(node::AssertionInfo const&) [/Users/luigi/code/node/out/Release/node]
 3: 0x10c77cdd4 node::(anonymous namespace)::ZlibStream::~ZlibStream() [/Users/luigi/code/node/out/Release/node]
 4: 0x10c9e50b5 unsigned long v8::internal::GlobalHandles::InvokeFirstPassWeakCallbacks<v8::internal::GlobalHandles::Node>(std::__1::vector<std::__1::pair<v8::internal::GlobalHandles::Node*, v8::internal::GlobalHandles::PendingPhantomCallback>, std::__1::allocator<std::__1::pair<v8::internal::GlobalHandles::Node*, v8::internal::GlobalHandles::PendingPhantomCallback> > >*) [/Users/luigi/code/node/out/Release/node]
 5: 0x10ca49f73 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*) [/Users/luigi/code/node/out/Release/node]
 6: 0x10ca47239 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/luigi/code/node/out/Release/node]
 7: 0x10cae6461 v8::internal::ScavengeJob::Task::RunInternal() [/Users/luigi/code/node/out/Release/node]
 8: 0x10c723f2e node::PerIsolatePlatformData::RunForegroundTask(std::__1::unique_ptr<v8::Task, std::__1::default_delete<v8::Task> >) [/Users/luigi/code/node/out/Release/node]
 9: 0x10c722857 node::PerIsolatePlatformData::FlushForegroundTasksInternal() [/Users/luigi/code/node/out/Release/node]
10: 0x10d22c79b uv__async_io [/Users/luigi/code/node/out/Release/node]
11: 0x10d2408e8 uv__io_poll [/Users/luigi/code/node/out/Release/node]
12: 0x10d22cc78 uv_run [/Users/luigi/code/node/out/Release/node]
13: 0x10c5ed713 node::SpinEventLoopInternal(node::Environment*) [/Users/luigi/code/node/out/Release/node]
14: 0x10c6fcde6 node::NodeMainInstance::Run() [/Users/luigi/code/node/out/Release/node]
15: 0x10c680f64 node::LoadSnapshotDataAndRun(node::SnapshotData const**, node::InitializationResultImpl const*) [/Users/luigi/code/node/out/Release/node]
16: 0x10c6811cd node::Start(int, char**) [/Users/luigi/code/node/out/Release/node]
17: 0x7ff801a73310 start [/usr/lib/dyld]
Abort trap: 6

I'm not sure if it is related.

ywave620 · 2022-12-19T02:41:28Z

After a stress test in Darwin MacBook-Pro.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:25:27 PDT 2022; root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64, I got a different assertion error

...
sending 759 bytes, buf size is 204747767
parse_chunk, length 759, total bytes received 1943006
sending 4381 bytes, buf size is 204747008
parse_chunk, length 4381, total bytes received 1947387
sending 3557 bytes, buf size is 204742627
parse_chunk, length 3557, total bytes received 1950944
sending 4974 bytes, buf size is 204739070
parse_chunk, length 4974, total bytes received 1955918
/Users/roger/Work/node-contribute/out/Debug/node[81933]: ../src/node_zlib.cc:752:void node::(anonymous namespace)::ZlibContext::Close(): Assertion `status == 0 || status == (-3)' failed.
 1: 0x1015e411d node::DumpBacktrace(__sFILE*) [/Users/roger/Work/node-contribute/out/Debug/node]
 2: 0x10176223b node::Abort() [/Users/roger/Work/node-contribute/out/Debug/node]
 3: 0x101761d95 node::Assert(node::AssertionInfo const&) [/Users/roger/Work/node-contribute/out/Debug/node]
 4: 0x101989385 node::(anonymous namespace)::ZlibContext::Close() [/Users/roger/Work/node-contribute/out/Debug/node]
 5: 0x10198917e node::(anonymous namespace)::CompressionStream<node::(anonymous namespace)::ZlibContext>::Close() [/Users/roger/Work/node-contribute/out/Debug/node]
 6: 0x101985141 node::(anonymous namespace)::CompressionStream<node::(anonymous namespace)::ZlibContext>::Close(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/roger/Work/node-contribute/out/Debug/node]
 7: 0x101d04e12 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/Users/roger/Work/node-contribute/out/Debug/node]
 8: 0x101d03b3f v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, unsigned long*, int) [/Users/roger/Work/node-contribute/out/Debug/node]
 9: 0x101d027db v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/Users/roger/Work/node-contribute/out/Debug/node]
10: 0x102d562f9 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit [/Users/roger/Work/node-contribute/out/Debug/node]

ywave620 · 2022-12-19T04:15:58Z

Given that the original crash message provided by MaddieLowe, I suspect that bad memory allocation/deallocation is to blame. Since node performs (de)compression in bg thread, I wonder are malloc and free thread safe? Folks in https://stackoverflow.com/questions/855763/is-malloc-thread-safe confirm that the one in glibc is thread safe, how about the one in mac/windows?

ywave620 · 2022-12-19T06:53:39Z

Given that the original crash message provided by MaddieLowe, I suspect that bad memory allocation/deallocation is to blame. Since node performs (de)compression in bg thread, I wonder are malloc and free thread safe? Folks in https://stackoverflow.com/questions/855763/is-malloc-thread-safe confirm that the one in glibc is thread safe, how about the one in mac/windows?

Yes, they are thread safe in mac(See https://opensource.apple.com/source/libmalloc/libmalloc-53.1.1/src/malloc.c.auto.html)

bnoordhuis · 2022-12-19T13:36:38Z

@lpinca reported removing CRC32_SIMD_SSE42_PCLMUL fixed it for him and that sounds plausible.

Just a hunch, but the xmm0-xmm15 registers are caller-saved. The SIMD version of zlib's crc32 definitely clobbers them. Maybe something somewhere is not saving the xmm registers when it should?

An easy way to test is to run under qemu twice, once with CPU = Intel Nehalem, then CPU = Intel Westmere.

If the first one works okay and the second one crashes, then that's a pretty good indicator; Westmere was when PCLMULQDQ was introduced.

ywave620 · 2022-12-20T02:46:31Z

@MaddieLowe Could you share some thought on why you write this project in the first place? what problem you want to conquer? how you come up with the anonymized-data, because I can not identify any straightforward purpose by reading the code. It may be helpful for debugging :)

lpinca · 2022-12-20T07:09:56Z

@ywave620 from the issue description

The application this is currently affecting is used for streaming medical imaging data to a viewer.

MaddieLowe · 2022-12-20T16:01:57Z

Hey, yeah, I've given some background in the Additional Information section, but I can tell you more about the anonymized data. We ingest a lot of patient data with the PHI stripped out of it, and some of the data triggers this bug and some does not. When I was trying to find the smallest amount of code to reproduce this issue I tried just sending random bytes over the socket in a structure similar to what we're using for our data, but that did not reproduce the issue. There is something about this specific data that causes it and I'm not sure what.

I think I talked about how the data is structured in some comments in the code but I can provide some more info. It's a size indicator followed by that number of bytes. For example, if I wanted to send my name and a message, this is what the data would look like:
6Maddie5howdy
The data I've given you is mostly nuls, to protect patient and business information. The original data was not filled with nuls of course - the crash seems to happen whether the data is mostly nuls or not.

Another thing I can tell you is that it seems like it's necessary to send the data in chunks in order to reproduce the issue. Initially when I was trying to reproduce it I sent the whole file over the socket, and that didn't crash. But when I started breaking the data into random amounts of bytes (trying to make it more like real life) it caused the crash.

credcore-dave · 2023-04-26T16:06:21Z

We're experiencing an issue that might be similar or the same issue. We are extracting zip files with Word DOCX's in them in nodejs, using the unzipper package which calls into node:zlib. Fairly recently things started breaking subtly, in one case on a developer's linux desktop and in another case in CI (also on Linux): the files would be extracted successfully, they were the correct length, but the content was corrupted. (We verified this with sha1sum).

After quite some debugging, we resolved the issue by pinning node to v18.12.1. Doing the same for our CI dockerfile (which runs our unit tests which include extracting the zipfile then trying to parse the DOCX files) fixed it there too. So, seems like a regression between 18.12.1 and 18.16.0. I see that for example upstream zlib was pulled in and some SIMD related compiler options were changed after those versions. If it helps, I can pin the exact nodejs version the regression happens for us?

bnoordhuis · 2023-04-27T09:05:26Z

@credcore-dave that'd be helpful, yes. Can you try the qemu thing from #45268 (comment) once you've identified the first failing release? You don't need to set up a whole vm, just running it through qemu-user-x86_64 is sufficient.

credcore-dave · 2023-04-27T13:11:09Z

@credcore-dave that'd be helpful, yes. Can you try the qemu thing from #45268 (comment) once you've identified the first failing release? You don't need to set up a whole vm, just running it through qemu-user-x86_64 is sufficient.

For our CI server:

18.15.0 is the last known good version of nodejs.

18.16.0 results in corrupted files.

credcore-dave · 2023-04-27T14:31:11Z

@credcore-dave that'd be helpful, yes. Can you try the qemu thing from #45268 (comment) once you've identified the first failing release? You don't need to set up a whole vm, just running it through qemu-user-x86_64 is sufficient.

I checked out node and on the main branch, built the project. When I ran our application with the compiled from source node and tried to ingest a zip file, the files were corrupt, and the xml parser we use to read the extracted files failed.

I then attempted to replicate the linked diff by removing the CRC32_SIMD_SSE42_PCLMUL compile flag from zlib.gyp. However I think because I'm on a different branch, the gyp file looked different. So I just removed it from everywhere I could find it, then I recompiled.

This time, I get a different error. The unzipper npm package we use (that calls into node-zlib) emitted a FILE_ENDED error. We've also seen this before too.

Forgot to mention: I'm on MacOS. My colleague, and our CI machine, are Linux. We've experienced both these issues on Linux too.

Edit: I went back to the previous version of zlib.gyp (https://raw.githubusercontent.com/nodejs/node/978cfad00502e43dff6df2c773b3f3d43453280e/deps/zlib/zlib.gyp) and recompiled, I still get the FILE_ENDED error.

bnoordhuis · 2023-04-27T20:47:01Z

18.15.0 is the last known good version of nodejs. 18.16.0 results in corrupted files.

There were no changes to deps/zlib or the zlib module in that time frame. I looked through all the other commits and there are a few that could conceivably cause this kind of fallout but it's hard to say for sure. Is it an option for you to find the offending commit with git bisect?

I had a look at that unzipper package but there's too much source code to figure out at a quick glance what exactly it's doing.

credcore-dave · 2023-05-10T06:35:11Z

Sorry for the delay in replying @bnoordhuis . I'll try and do some bisecting when I have a bit more free time and get back to you.

lpinca · 2023-05-18T09:34:08Z

I've run the test case under qemu with -cpu Nehalem-v2 and -cpu Westmere-v2 as per #45268 (comment). I can reproduce the issue only with -cpu Westmere-v2 so I think @bnoordhuis's guess is correct.

$ qemu-x86_64 -cpu Nehalem-v2 /home/luigi/.nvm/versions/node/v20.2.0/bin/node index.js # The issue is not reproducible
$ qemu-x86_64 -cpu Westmere-v2 /home/luigi/.nvm/versions/node/v20.2.0/bin/node index.js # The issue is reproducible

lpinca · 2023-05-18T09:38:37Z

cc: @Adenilson

credcore-dave · 2023-09-06T07:41:15Z

This issue is now blocking us from upgrading nodejs in production. Could the CPU-specific code causing it be reverted please? 18.15.0 is still the last known good node for us.

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268

Adenilson · 2023-09-06T19:35:43Z

I got a few questions that I hope could better insulate what the problem is, please check below:

a) The report of reproducing on Mac, is it a M1 (Apple Silicon) macintosh or an Intel based?

b) Is there a standalone repro case (i.e. relies only on zlib proper) that I could have access?

The macro CRC32_SIMD_SSE42_PCLMUL guards the x86 vectorized implementation of CRC-32 in Chromium zlib.

I would be quite surprised if that is the culprit for the observed misbehavior, since we have shipped it since 2018.

There is one macro that guards an optimization that can be impacted by misbehaved client code though i.e. code that relies on undefined behavior present in canonical zlib that has changed thanks to this specific optimization.

The macro is INFLATE_CHUNK_SIMD_SSE2, and I even mentioned it in the source code (i.e. https://github.com/nodejs/node/blob/main/deps/zlib/contrib/optimizations/inflate.c#L1256).

What happens if you disable the above macro?

lpinca · 2023-09-06T20:10:57Z

a) The report of reproducing on Mac, is it a M1 (Apple Silicon) macintosh or an Intel based?

Intel based Mac (3,2 GHz 8-Core Intel Xeon W). I have just tried again compiling the main branch, and it crashed after 2/3 runs

node(54825,0x7ff8568e6700) malloc: Incorrect checksum for freed object 0x7f881d00c200: probably modified after being freed.
Corrupt value: 0x0
node(54825,0x7ff8568e6700) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6

b) Is there a standalone repro case (i.e. relies only on zlib proper) that I could have access?

I don't have one.

The macro is INFLATE_CHUNK_SIMD_SSE2, and I even mentioned it in the source code (i.e. https://github.com/nodejs/node/blob/main/deps/zlib/contrib/optimizations/inflate.c#L1256).

What happens if you disable the above macro?

I'm currently compiling Node.js on WSL where the issue is easier to reproduce. I will let you know.

lpinca · 2023-09-06T20:57:53Z

I have to sleep, I'll update tomorrow.

lpinca · 2023-09-07T05:42:33Z

With #49511 reverted I can still reproduce the issue after applying this patch

diff --git a/deps/zlib/zlib.gyp b/deps/zlib/zlib.gyp
index 49de2a6c6d..70a05e40db 100644
--- a/deps/zlib/zlib.gyp
+++ b/deps/zlib/zlib.gyp
@@ -134,43 +134,6 @@
             '<!@pymod_do_main(GN-scraper "<(ZLIB_ROOT)/BUILD.gn" "\\"zlib_crc32_simd\\".*?sources = ")',
           ],
         }, # zlib_crc32_simd
-        {
-          'target_name': 'zlib_inflate_chunk_simd',
-          'type': 'static_library',
-          'conditions': [
-            ['target_arch in "ia32 x64" and OS!="ios"', {
-              'defines': [ 'INFLATE_CHUNK_SIMD_SSE2' ],
-              'conditions': [
-                ['target_arch=="x64"', {
-                  'defines': [ 'INFLATE_CHUNK_READ_64LE' ],
-                }],
-              ],
-            }],
-            ['arm_fpu=="neon"', {
-              'defines': [ 'INFLATE_CHUNK_SIMD_NEON' ],
-              'conditions': [
-                ['target_arch=="arm64"', {
-                  'defines': [ 'INFLATE_CHUNK_READ_64LE' ],
-                }],
-              ],
-            }],
-          ],
-          'include_dirs': [ '<(ZLIB_ROOT)' ],
-          'direct_dependent_settings': {
-            'conditions': [
-              ['target_arch in "ia32 x64" and OS!="ios"', {
-                'defines': [ 'INFLATE_CHUNK_SIMD_SSE2' ],
-              }],
-              ['arm_fpu=="neon"', {
-                'defines': [ 'INFLATE_CHUNK_SIMD_NEON' ],
-              }],
-            ],
-            'include_dirs': [ '<(ZLIB_ROOT)' ],
-          },
-          'sources': [
-            '<!@pymod_do_main(GN-scraper "<(ZLIB_ROOT)/BUILD.gn" "\\"zlib_inflate_chunk_simd\\".*?sources = ")',
-          ],
-        }, # zlib_inflate_chunk_simd
         {
           'target_name': 'zlib',
           'type': 'static_library',
@@ -199,8 +162,11 @@
             }],
             # Incorporate optimizations where possible.
             ['(target_arch in "ia32 x64" and OS!="ios") or arm_fpu=="neon"', {
-              'dependencies': [ 'zlib_inflate_chunk_simd' ],
-              'sources': [ '<(ZLIB_ROOT)/slide_hash_simd.h' ]
+              # 'dependencies': [ 'zlib_inflate_chunk_simd' ],
+              'sources': [
+                '<(ZLIB_ROOT)/inflate.c',
+                '<(ZLIB_ROOT)/slide_hash_simd.h',
+              ]
             }, {
               'defines': [ 'CPU_NO_SIMD' ],
               'sources': [ '<(ZLIB_ROOT)/inflate.c' ],

Also, if the issue was with INFLATE_CHUNK_SIMD_SSE2 it would still be reproducible in #49511, no?, but it is not.

bnoordhuis · 2023-09-08T07:53:25Z

The macro CRC32_SIMD_SSE42_PCLMUL guards the x86 vectorized implementation of CRC-32 in Chromium zlib. I would be quite surprised if that is the culprit for the observed misbehavior, since we have shipped it since 2018.

It's quite possible chromium's zlib is blameless. It's been a while since I last looked at this issue but I remember seeing hints of xmm registers not being saved by callers. I have some jotted-down notes where I was apparently suspicious of xmm7 getting clobbered across calls.

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: #45268 PR-URL: #49511 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Adenilson · 2023-09-11T18:33:24Z

@bnoordhuis It seems that disabling CRC32_PCLMUL will be a regression of around -20% in decompression speed and -15% in compression speed.

Could you (or someone from the node.js team) elaborate further on how the calls are performed between node.sj <--> zlib?

bnoordhuis · 2023-09-11T19:00:58Z

The relevant code is in src/node_zlib.cc. We're not doing anything out of the ordinary, our C++ code just call zlib's public API.

I entertained the idea that we may be miscompiling node or zlib somehow (missing or wrong compiler flags) but nothing Obviously Wrong stood out to me at the time.

lpinca · 2023-09-12T04:58:52Z

I think there is something wrong in our benchmarks or I ran the job incorrectly. See #49511 (comment).

Adenilson · 2023-09-12T17:00:37Z

@lpinca I measured using zlib_bench (https://source.chromium.org/chromium/chromium/src/+/main:third_party/zlib/contrib/bench/zlib_bench.cc), where the data is all in memory and it calculates raw compression/decompression speeds of zlib.

If values are smaller than what I've reported, that probably means that there are other bottlenecks probably in moving data between node.js <--> zlib, such that data integrity checks (i.e. CRC32) is not the limiting factor.

lpinca · 2023-09-12T19:40:35Z

@Adenilson yes I understand. What I find surprising is that our benchmarks show improvements without the CRC32 SIMD optimization. They just compare before and after.

Adenilson · 2023-09-14T03:49:04Z

@lpinca what would be distribution of lengths of data vectors passed to zlib (i.e. the 'len' in crc32_z, https://source.chromium.org/chromium/chromium/src/+/main:third_party/zlib/crc32.c;l=702) during the benchmarks?

If lengths are short (i.e. smaller than the threshold to enter vectorized code), we fallback to the portable code.

This is really hot code and by disabling CRC32_SIMD_SSE42_PCLMUL quite a few branches are removed from the the hot path.

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: #45268 PR-URL: #49511 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268 PR-URL: nodejs#49511 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

lpinca added the zlib Issues and PRs related to the zlib subsystem. label Nov 1, 2022

jpwilliams mentioned this issue Jun 9, 2023

Unable to run npx inngest-cli@latest dev on Windows 11 inngest/inngest#449

Closed

jpwilliams mentioned this issue Aug 18, 2023

Fix CLI streaming issue and pin Windows to 0.14.6 inngest/inngest#575

Merged

8 tasks

lpinca mentioned this issue Sep 6, 2023

zlib: disable CRC32 SIMD optimization #49511

Merged

lpinca added a commit to lpinca/node that referenced this issue Sep 6, 2023

zlib: disable CRC32 SIMD optimization

9b92376

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268

lpinca added a commit to lpinca/node that referenced this issue Sep 6, 2023

zlib: disable CRC32 SIMD optimization

d39b222

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268

lpinca added a commit to lpinca/node that referenced this issue Sep 6, 2023

zlib: disable CRC32 SIMD optimization

a7bb3ee

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268

lpinca added a commit to lpinca/node that referenced this issue Sep 6, 2023

zlib: disable CRC32 SIMD optimization

550a760

It seems that the optimization causes memory corruption. Disable it until the issue is fixed upstream. Fixes: nodejs#45268

nodejs-github-bot closed this as completed in #49511 Sep 10, 2023

credcore-dave mentioned this issue Dec 27, 2023

Getting FILE_ENDED with some routes through code ZJONSSON/node-unzipper#231

Open

Memory corruption and crash when streaming to zlib #45268

Memory corruption and crash when streaming to zlib #45268

Comments

MaddieLowe commented Nov 1, 2022

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

lpinca commented Nov 1, 2022

lpinca commented Nov 16, 2022

lpinca commented Nov 17, 2022

lpinca commented Nov 20, 2022

ywave620 commented Dec 16, 2022

lpinca commented Dec 16, 2022

ywave620 commented Dec 17, 2022

lpinca commented Dec 17, 2022 • edited Loading

ywave620 commented Dec 19, 2022

ywave620 commented Dec 19, 2022 • edited Loading

ywave620 commented Dec 19, 2022

bnoordhuis commented Dec 19, 2022

ywave620 commented Dec 20, 2022 • edited Loading

lpinca commented Dec 20, 2022

MaddieLowe commented Dec 20, 2022

credcore-dave commented Apr 26, 2023 • edited Loading

bnoordhuis commented Apr 27, 2023

credcore-dave commented Apr 27, 2023

credcore-dave commented Apr 27, 2023 • edited Loading

bnoordhuis commented Apr 27, 2023

credcore-dave commented May 10, 2023

lpinca commented May 18, 2023

lpinca commented May 18, 2023

credcore-dave commented Sep 6, 2023 • edited Loading

Adenilson commented Sep 6, 2023

lpinca commented Sep 6, 2023

lpinca commented Sep 6, 2023

lpinca commented Sep 7, 2023

bnoordhuis commented Sep 8, 2023

Adenilson commented Sep 11, 2023

bnoordhuis commented Sep 11, 2023

lpinca commented Sep 12, 2023

Adenilson commented Sep 12, 2023

lpinca commented Sep 12, 2023 • edited Loading

Adenilson commented Sep 14, 2023

lpinca commented Dec 17, 2022 •

edited

Loading

ywave620 commented Dec 19, 2022 •

edited

Loading

ywave620 commented Dec 20, 2022 •

edited

Loading

credcore-dave commented Apr 26, 2023 •

edited

Loading

credcore-dave commented Apr 27, 2023 •

edited

Loading

credcore-dave commented Sep 6, 2023 •

edited

Loading

lpinca commented Sep 12, 2023 •

edited

Loading