Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: supported or should a userland module be used #4532

Closed
geek opened this issue Jan 4, 2016 · 3 comments
Closed

assert: supported or should a userland module be used #4532

geek opened this issue Jan 4, 2016 · 3 comments
Labels
assert Issues and PRs related to the assert subsystem. question Issues that look for answers.

Comments

@geek
Copy link
Member

geek commented Jan 4, 2016

In the docs at https://nodejs.org/api/assert.html it states:

it is recommended that a userland assertion library be used instead.

Is this still a valid statement, or should we remove this line as the assert module is marked as stable and locked?

@mscdex mscdex added assert Issues and PRs related to the assert subsystem. question Issues that look for answers. labels Jan 4, 2016
@sam-github
Copy link
Contributor

stable and locked doesn't mean "good for all purposes".

I think the statement should be qualified to add "For the purposes of unit testing, it is recommended that a userland unit test library be used instead."

Apparently some people think that the assert lib is for unit testing, and then complain about missing features. While it is used for unit testing in node... that is unusual, its mostly for in-source assertion of invariants.

@mscdex
Copy link
Contributor

mscdex commented Jan 5, 2016

+1 to what @sam-github said.

@mikeal
Copy link
Contributor

mikeal commented Jan 5, 2016

Could be a little stronger:

This module is intended for the unit tests in Node.js core. It is recommended that users of Node.js choose a third party assertion library from npm.

MylesBorins pushed a commit that referenced this issue Jan 11, 2016
Fixes: #4532
PR-URL: #4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 12, 2016
Fixes: #4532
PR-URL: #4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 13, 2016
Fixes: #4532
PR-URL: #4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 14, 2016
Fixes: #4532
PR-URL: #4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
Fixes: #4532
PR-URL: #4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
Fixes: nodejs#4532
PR-URL: nodejs#4535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

4 participants