Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --test-name-pattern in run() #46045

Closed
connor4312 opened this issue Jan 1, 2023 · 3 comments
Closed

Support --test-name-pattern in run() #46045

connor4312 opened this issue Jan 1, 2023 · 3 comments
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.

Comments

@connor4312
Copy link
Contributor

What is the problem this feature will solve?

Currently, --test-name-pattern can be provided when running tests from the command line, but not when running them via the run() API.

What is the feature you are proposing to solve the problem?

Have a new option like namePatterns?: string[] in the options.

What alternatives have you considered?

No response
@connor4312 connor4312 added the feature request Issues that request new features to be added to Node.js. label Jan 1, 2023
@cjihrig cjihrig added the test_runner Issues and PRs related to the test runner subsystem. label Jan 1, 2023
@MoLow MoLow added the good first issue Issues that are suitable for first-time contributors. label Feb 4, 2023
@italojs
Copy link
Contributor

italojs commented Feb 5, 2023

working on it

@italojs italojs mentioned this issue Feb 6, 2023
Closed
@connor4312 connor4312 mentioned this issue Feb 19, 2023
Closed
@atlowChemi
Copy link
Member

I'd like to work on this, if that's ok

atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 19, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
31e21f0 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 19, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
a08f221 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 19, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
3fb7c7e 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
@atlowChemi atlowChemi mentioned this issue Apr 19, 2023
Closed
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 19, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
c7c46e2 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 20, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
fa9f118 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 20, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
72137fd 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
atlowChemi added a commit to atlowChemi/node that referenced this issue Apr 20, 2023
@atlowChemi
test_runner: add testNamePatterns to run api
dea6914 
Accept a `testNamePatterns` value in the `run` fn, and drill those
patterns to the spawned processes.
Fixes: nodejs#46045
@MoLow
Copy link
Member

MoLow commented Apr 24, 2023

closed by c627969

@MoLow MoLow closed this as completed Apr 24, 2023
@avivkeller avivkeller moved this from Awaiting Triage to Done in Node.js feature requests Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
5 participants
@connor4312 @cjihrig @MoLow @italojs @atlowChemi