Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the riscv64 compilation path to the wrong one #46154

Closed
luyahan opened this issue Jan 10, 2023 · 2 comments
Closed

Changed the riscv64 compilation path to the wrong one #46154

luyahan opened this issue Jan 10, 2023 · 2 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@luyahan
Copy link
Contributor

luyahan commented Jan 10, 2023 •
edited
Loading

Version

18.x-staging

Platform

riscv64

What steps will reproduce the bug?

48cf890
Changed the riscv64 compilation path to the wrong one
18.x don't include the RISC-V 32-bit support in V8 the directory

What is the expected behavior?

build pass

What do you see instead?

Build failed
@luyahan luyahan mentioned this issue Jan 10, 2023
Closed
@F3n67u F3n67u added the build Issues and PRs related to build files or the CI. label Jan 11, 2023
@F3n67u
Copy link
Member

F3n67u commented Jan 11, 2023

@targos Seems that we should also add "don't land on v18.x" label to #45149 because in v18.x branch src/heap/base/asm/riscv64 has not renamed to riscv yet. See https://github.com/nodejs/node/tree/v18.x/deps/v8/src/heap/base/asm.

@targos
Copy link
Member

targos commented Jan 11, 2023

It's too late. The commit is already on v18.x. That's why this issue was opened.

@luyahan luyahan closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @F3n67u @luyahan