Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] tools: Revert "tools: update V8 gypfiles for RISC-V" #46156

Closed
wants to merge 1 commit into from
Closed

[v18.x] tools: Revert "tools: update V8 gypfiles for RISC-V" #46156

wants to merge 1 commit into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Jan 10, 2023

Fix wrong file path
fix #46154

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jan 10, 2023
@targos targos changed the title Revert "tools: update V8 gypfiles for RISC-V" [v18.x] Revert "tools: update V8 gypfiles for RISC-V" Jan 10, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48927/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5115/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5115/

@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Open
24 tasks
@luyahan luyahan changed the title [v18.x] Revert "tools: update V8 gypfiles for RISC-V" [v18.x] tools: Revert "tools: update V8 gypfiles for RISC-V" Jan 11, 2023
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5115/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48942/

This was referenced Jan 12, 2023
Open
Open
Open
Open
Open
Open
Open
juanarbol pushed a commit that referenced this pull request Jan 22, 2023
@luyahan @juanarbol
Revert "tools: update V8 gypfiles for RISC-V"
1e11247 
This reverts commit 48cf890.

PR-URL: #46156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
@MylesBorins
Copy link
Contributor

landed in 1e11247b91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@luyahan @nodejs-github-bot @MylesBorins @targos @richardlau @juanarbol