-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO/XXX in tools directory #4635
Comments
postinstall doesn't even actually run in the OS X installer (no one knows how pkgmaker actually works) |
I can probably start on this. At least with the first one to begin with... |
@Trott @Fishrock123 Regarding number one, I saw that the expected prefix is not removed if a user is on a Windows machine. This happens because the self.Fullname() converts backslashes to forward slashes. def FullName(self):
"""Make Windows paths like Unix."""
return os.path.abspath(self._filename).replace('\\', '/') Conversely, the toplevel operation does not do this so the resulting prefix will only contain The difference in return values will be Note that the Code directory is just where my node repo lives. |
@trendsetter37 That seems about right. As a note, IIRC we don't actually run cpplint on Windows, so it could be a step to resolving that. |
@Trott ... any reason to keep this open? |
(copy/pasted from a related issue) @jasnell I'm OK with closing this and the other TODO/XXX/FIXME issues. If any of those items are things that really ought to be fixed (rather than a wishlist or a "will fix after Magical Feature X is available"), a separate issue should be opened anyway because it's just getting lost in these out-of-date tracking issues. While I think this issue is superfluous personally, anyone else should feel free to re-open (if GitHub permits them to) or comment requesting this be re-opened. |
Ref: #264
There are two TODO comments and one XXX comment in the
tools
directory that were placed there by project authors (as opposed to pre-existing in tools imported from outside the project). It would be great to either remove them from the code (if they are no longer valid or at least not particularly high value), or get issues opened for them, or just get whatever it is they are addressing addressed. Here they are as of this writing.1: cpplint.py:
There are other comments TODO etc. comments in
cpplint.py
but they were already there when the external project was first imported into the Node.js project.2 and 3: osx-pkg-postinstall.sh
cc @bnoordhuis
The text was updated successfully, but these errors were encountered: