Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: unify the header treatment #46395

Closed
climba03003 opened this issue Jan 28, 2023 · 1 comment · Fixed by #46528
Closed

http: unify the header treatment #46395

climba03003 opened this issue Jan 28, 2023 · 1 comment · Fixed by #46528
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@climba03003
Copy link
Contributor

climba03003 commented Jan 28, 2023 •
edited
Loading

What is the problem this feature will solve?

This issue is similar to #42579.
We know that the header serialization will be treat differently when the header of Transfer-Encoding: chunked exists or not.

Being two different behavior for serialize the header is causing problem if people do not know how it works.
So, here is an ask for unify the behavior between two.

Related fastify/fastify-reply-from#287

cc @SimenB @mcollina @ShogunPanda

What is the feature you are proposing to solve the problem?

It should either throw with proper error or convert to latin1 in all case.
I would prefer throwing with an proper explanation.

What alternatives have you considered?

Always check in user-land code, but it is problematic and easily to forgot.
@climba03003 climba03003 added the feature request Issues that request new features to be added to Node.js. label Jan 28, 2023
@marco-ippolito
Copy link
Member

I will work on this, opening a PR soon

@marco-ippolito marco-ippolito mentioned this issue Feb 6, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Feb 21, 2023
@marco-ippolito
http: unify header treatment
3fd4343 
PR-URL: #46528
Fixes: #46395
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos pushed a commit that referenced this issue Mar 13, 2023
@marco-ippolito @targos
http: unify header treatment
6f9cb98 
PR-URL: #46528
Fixes: #46395
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this issue Apr 11, 2023
@marco-ippolito @danielleadams
http: unify header treatment
23c1e2f 
PR-URL: #46528
Fixes: #46395
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@marco-ippolito marco-ippolito mentioned this issue Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: unify header treatment marco-ippolito/node
2 participants
@climba03003 @marco-ippolito