-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot cross-compile with ninja #46690
Comments
The exact same behavior also occurs on |
I don't think cross-compiling with ninja has ever worked. For anyone wanting to work on this, it probably requires applying fixes to https://github.com/nodejs/gyp-next/blob/main/pylib/gyp/generator/ninja.py |
Seems like a duplicate of #37441. Also if you scroll down you can see that a fix (or workaround) is available in a fork minrk@5e533cb, which is in use by buildroot |
Oh, indeed it is. I'll close it as such then. |
avoids duplicate ninja rules for v8 used in host and target From: minrk/node@5e533cb Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reported in nodejs/node#46690 and nodejs/node#37441 Signed-off-by: Tim Orling <tim.orling@konsulko.com>
avoids duplicate ninja rules for v8 used in host and target From: minrk/node@5e533cb Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reported in nodejs/node#46690 and nodejs/node#37441 Minor refactoring as recommended by Christian Clauss. Signed-off-by: Tim Orling <tim.orling@konsulko.com>
avoids duplicate ninja rules for v8 used in host and target From: minrk/node@5e533cb Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reported in nodejs/node#46690 and nodejs/node#37441 Minor refactoring as recommended by Christian Clauss. Signed-off-by: Tim Orling <tim.orling@konsulko.com>
avoids duplicate ninja rules for v8 used in host and target From: minrk/node@5e533cb Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reported in nodejs/node#46690 and nodejs/node#37441 Minor refactoring as recommended by Christian Clauss. Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Version
19.6.0 (actually git 1b87cb6)
Platform
Linux oss-tx204 5.15.0-41-generic #44-Ubuntu SMP Thu Jun 23 11:20:13 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
Configure node to use the cross-compile rules with ninja, then try building it:
This doesn't happen if using ninja but not cross-compiling, or if cross-compiling without ninja.
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
No response
What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: