-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-http2-large-file is flaky #47409
Comments
I took https://ci.nodejs.org/computer/test-osuosl-aix72-ppc64_be-2/ offline to investigate |
on AIX diff --git a/test/sequential/test-http2-large-file.js b/test/sequential/test-http2-large-file.js
index 2f2cc2c80d..3afcec73f4 100644
--- a/test/sequential/test-http2-large-file.js
+++ b/test/sequential/test-http2-large-file.js
@@ -24,6 +24,7 @@ server.listen(0, common.mustCall(() => {
{ settings: { initialWindowSize: 6553500 } });
const request = client.request({ ':method': 'POST' });
function writeChunk() {
+ console.log({ remaining });
if (remaining > 0) {
remaining -= chunkLength;
request.write(chunk, writeChunk); |
There's a long history of |
it does not seem to be a race condition, this did not fix the issue: diff --git a/test/sequential/test-http2-large-file.js b/test/sequential/test-http2-large-file.js
index 2f2cc2c80d..300e0642ab 100644
--- a/test/sequential/test-http2-large-file.js
+++ b/test/sequential/test-http2-large-file.js
@@ -24,12 +24,14 @@ server.listen(0, common.mustCall(() => {
{ settings: { initialWindowSize: 6553500 } });
const request = client.request({ ':method': 'POST' });
function writeChunk() {
- if (remaining > 0) {
+ setTimeout(() => {
+ if (remaining > 0) {
remaining -= chunkLength;
request.write(chunk, writeChunk);
} else {
request.end();
}
+ }, 10); |
I forget (or maybe never knew!) the details, but |
|
@miladfarca has been investigating this as an upstream V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=13902 |
https://ci.nodejs.org/computer/test-osuosl-aix72-ppc64_be-2/ is back online |
Happened on Windows and Linux with https://ci.nodejs.org/job/node-test-pull-request/56726/ |
The V8 issue talks about disabling concurrent sparkplug to fix it temporarily but we already do it: 7071c1d Related:
|
The first time it occurred in this build https://ci.nodejs.org/job/node-daily-master/3286/, so i guess something that landed around 7th of Jan might've caused this. From what I can see the difference is this commit 1a5acd0 |
Refs: nodejs#47409 PR-URL: nodejs#51549 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Refs: nodejs#47409 PR-URL: nodejs#51549 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Refs: nodejs#47409 PR-URL: nodejs#51549 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Test
test-http2-large-file
Platform
AIX
Console output
Build links
Additional information
No response
The text was updated successfully, but these errors were encountered: