Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value argument to URLSearchParams's has() and delete() #47883

Closed
annevk opened this issue May 5, 2023 · 2 comments · Fixed by #47885
Closed

Add value argument to URLSearchParams's has() and delete() #47883

annevk opened this issue May 5, 2023 · 2 comments · Fixed by #47885
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@annevk
Copy link

annevk commented May 5, 2023

This was the most-requested feature in the URL Standard backlog.

Standard: whatwg/url#735.

WPT: web-platform-tests/wpt#39865.
@annevk annevk mentioned this issue May 5, 2023
Merged
4 tasks
@anonrig anonrig added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 5, 2023
@sankalp1999
Copy link
Contributor

hi I would like to help with this.

@debadree25
Copy link
Member

Go for it!

sankalp1999 added a commit to sankalp1999/node that referenced this issue May 5, 2023
@sankalp1999
url: add value argument to has and delete methods
7cc66e4 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: nodejs#47883
@sankalp1999 sankalp1999 mentioned this issue May 5, 2023
Merged
sankalp1999 added a commit to sankalp1999/node that referenced this issue May 5, 2023
@sankalp1999
url: added wpt tests using git node wpt url
12b462b 
Added the wpt tests using git node wpt url

Fixes: nodejs#47883
@hamishwillee hamishwillee mentioned this issue May 8, 2023
Closed
sankalp1999 added a commit to sankalp1999/node that referenced this issue May 8, 2023
@sankalp1999
url: add value argument to has and delete methods
7d99ffc 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: nodejs#47883
nodejs-github-bot pushed a commit that referenced this issue May 14, 2023
@sankalp1999
url: add value argument to has and delete methods
9f3aacb 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: #47883
PR-URL: #47885
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this issue May 14, 2023
@sankalp1999 @targos
url: add value argument to has and delete methods
8d65fb8 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: #47883
PR-URL: #47885
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this issue May 15, 2023
@sankalp1999 @targos
url: add value argument to has and delete methods
a0634d7 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: #47883
PR-URL: #47885
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
ruyadorno pushed a commit that referenced this issue Sep 6, 2023
@sankalp1999 @ruyadorno
url: add value argument to has and delete methods
c59ae86 
The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: #47883
PR-URL: #47885
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: add value argument to has and delete methods sankalp1999/node
4 participants
@annevk @anonrig @debadree25 @sankalp1999