-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node:test beforeEach and afterEach generate MaxListenersExceededWarning #48475
Labels
test_runner
Issues and PRs related to the test runner subsystem.
Comments
atlowChemi
added
the
test_runner
Issues and PRs related to the test runner subsystem.
label
Jun 20, 2023
will fix it now |
Can i take a look at it ? |
rluvaton
added a commit
to rluvaton/node
that referenced
this issue
Jul 25, 2023
Sorry, missed that. maybe next time? |
rluvaton
added a commit
to rluvaton/node
that referenced
this issue
Jul 29, 2023
pluris
pushed a commit
to pluris/node
that referenced
this issue
Aug 6, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris
pushed a commit
to pluris/node
that referenced
this issue
Aug 7, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this issue
Aug 14, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this issue
Aug 15, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton
added a commit
to rluvaton/node
that referenced
this issue
Aug 18, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton
added a commit
to rluvaton/node
that referenced
this issue
Sep 4, 2023
fix nodejs#48475 PR-URL: nodejs#48915 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v20.3.0
Platform
No response
Subsystem
node:test
What steps will reproduce the bug?
Run tests with
node --test
How often does it reproduce? Is there a required condition?
Consistently with 11 or more tests that share a beforeEach or afterEach hook. This does not occur if each test has its own after hook, e.g.:
test(`${i}`, (t) => t.after(() => {}))
What is the expected behavior? Why is that the expected behavior?
No warning should be emitted when running the tests. It is reasonable to have more than 10 unit tests that share a beforeEach and/or afterEach hook, and explicitly using
events.setMaxListeners()
in the unit tests should not be necessary to avoid the warning.What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: