-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader preload code never executes #48778
Labels
Comments
I'm able to reproduce with |
aduh95
added
confirmed-bug
Issues with confirmed bugs.
loaders
Issues and PRs related to ES module loaders
labels
Jul 15, 2023
aduh95
added a commit
that referenced
this issue
Jul 17, 2023
pluris
pushed a commit
to pluris/node
that referenced
this issue
Aug 6, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
pluris
pushed a commit
to pluris/node
that referenced
this issue
Aug 7, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this issue
Aug 14, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS
pushed a commit
that referenced
this issue
Aug 15, 2023
targos
pushed a commit
to targos/node
that referenced
this issue
Nov 11, 2023
PR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
targos
pushed a commit
that referenced
this issue
Nov 23, 2023
sercher
added a commit
to sercher/graaljs
that referenced
this issue
Apr 25, 2024
PR-URL: nodejs/node#48779 Backport-PR-URL: nodejs/node#50669 Fixes: nodejs/node#48778 Fixes: nodejs/node#48516 Refs: nodejs/node#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
sercher
added a commit
to sercher/graaljs
that referenced
this issue
Apr 25, 2024
PR-URL: nodejs/node#48779 Backport-PR-URL: nodejs/node#50669 Fixes: nodejs/node#48778 Fixes: nodejs/node#48516 Refs: nodejs/node#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
v20.0.0
Platform
Linux silica 5.19.0-45-generic #46-Ubuntu SMP PREEMPT_DYNAMIC Wed Jun 7 09:08:58 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
Loader API
What steps will reproduce the bug?
loader.mjs
.node --loader=./loader.mjs
.PRELOAD
message is logged.BOOTSTRAP
message is never logged.How often does it reproduce? Is there a required condition?
Consistently on any v20 release.
What is the expected behavior? Why is that the expected behavior?
The string returned by
globalPreload()
is executed on the main thread. The API docs claim it will happen.What do you see instead?
The string returned by
globalPreload()
is never executed.Additional information
On the latest v19 this code works.
On the earliest v20 the returned string never executes.
I tried setting a global property in the bootstrap code to ensure it wasn't just a
console
issue. The property is never set.Could have sworn I saw this working before on v20, but it fails consistently now. I tried it on 2 different machines, one with fresh install of Node.js, with the same result everywhere.
Would really like to use the loader thread. It seems like they should be isolated. But I've got to stick with v19 until I can run a bootstrap at startup.
The text was updated successfully, but these errors were encountered: