Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-tls-fast-writing #4964

Closed
Trott opened this issue Jan 30, 2016 · 7 comments
Closed

Investigate flaky test-tls-fast-writing #4964

Trott opened this issue Jan 30, 2016 · 7 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Jan 30, 2016

Example failure: vs2015,win10

@Trott Trott added the test Issues and PRs related to the tests. label Jan 30, 2016
@mscdex mscdex added tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform. labels Jan 30, 2016
@Trott
Copy link
Member Author

Trott commented Feb 1, 2016

The original commit that landed this test seems to suggest that its purpose is to test that data is read again after drain fires.

The failure above seems to suggest that drain never fired (even though conn.write() had to return false at some point or the while loop would have locked up the thread and the test would have timed out).

This is the first time I've ever seen this test fail in CI (that I can recall, anyway).

And the stress test didn't result in any failures.

I'm inclined to close this. It can be re-opened if the test ever fails again, of course (or maybe if someone on @nodejs/platform-windows has any particular insights or interest in the issue).

@Trott Trott closed this as completed Feb 1, 2016
@santigimeno
Copy link
Member

@Trott I saw a TIMEOUT failure with this test in OS X. I can't seem to reproduce it though :(

@Trott
Copy link
Member Author

Trott commented Feb 1, 2016

@santigimeno reporting having seen this too, so reopening.

@Trott
Copy link
Member Author

Trott commented Feb 28, 2016

PR to increase the timeout: #5466

Trott added a commit to Trott/io.js that referenced this issue Feb 29, 2016
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.

Fixes: nodejs#4964
@Trott Trott closed this as completed in c133d07 Mar 2, 2016
Fishrock123 pushed a commit that referenced this issue Mar 2, 2016
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.

Fixes: #4964
PR-URL: #5466
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.

Fixes: #4964
PR-URL: #5466
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.

Fixes: #4964
PR-URL: #5466
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.

Fixes: #4964
PR-URL: #5466
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

Reopening due to a failure here:

https://ci.nodejs.org/job/node-test-commit-linux/15935/nodes=debian8-x86/console

  duration_ms: 0.169
  severity: fail
  stack: |-
  ...

@BridgeAR BridgeAR reopened this Feb 1, 2018
@BridgeAR BridgeAR added macos Issues and PRs related to the macOS platform / OSX. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 1, 2018
@apapirovski
Copy link
Member

I think this was a stackless error which is tracked elsewhere so I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

5 participants