-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sequential.test-watch-mode-inspect seems flaky #49933
Comments
Failed on same machine, two builds in a row |
Passed when it ran on test-equinix-ubuntu2204-x64-2 so could be specific to that machine. Need to track to see if it fails across the machines or not. |
Interestingly I see this in the output not ok 3844 sequential/test-watch-mode-inspect # TODO : Fix flaky test which seems to say it's a known issue even though I could not find a tracking issue. |
FWIW the test is already marked flaky node/test/sequential/sequential.status Lines 10 to 12 in 1b96975
https://ci.nodejs.org/job/node-test-binary-armv7l/7720/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/console has failed because of leftover Node.js processes (which are probably related to the test being timed out): 17:02:09 All tests passed.
17:02:09 ps awwx | grep Release/node | grep -v grep | cat
17:02:09 2212632 ? Sl 0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 --watch /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
17:02:09 2212638 ? Sl 0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
17:02:09 make: *** [Makefile:538: test-ci-js] Error 1 |
It failed on again on ubuntu 22.04 https://ci.nodejs.org/job/node-test-commit-osx-arm/13900/ |
Seen on |
I don't see if failing in https://ci.nodejs.org/job/node-test-commit-osx-arm/13900/, that seemed to be a different test |
PR-URL: nodejs#50259 Refs: nodejs#49933 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Not sure why I keep seeing these even though the test is marked as flaky. Looked at the CI jobs and I don't see anything obviously wrong. @richardlau do you know of any reason off the top of your head a job might not be treating flaky tests as ok? |
@mhdawson https://ci.nodejs.org/job/node-test-binary-armv7l/9064/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/console failed because: 18:27:41 All tests passed.
18:27:41 ps awwx | grep Release/node | grep -v grep | cat
18:27:41 601756 ? Sl 0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 --watch /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
18:27:41 601762 ? Sl 0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
18:27:41 make: *** [Makefile:538: test-ci-js] Error 1 "All tests passed" means that the failure was treated as flaky. The problem is that it left behind child processes and the build will fail if any node process are still running after the test runner exits: Lines 554 to 559 in 342ddb0
|
@richardlau, if I get what you are saying is that even though the job out reports this test, that was not the problem, instead it was because child processes were left behind that may/likely have nothing to do with that flaky test right? |
@mhdawson Yes, although I suspect the leftover processes are from the flaky test which I believe has been timed out. |
@richardlau ok, if we believe they are related to the test then SKIP might be more appropriate right? If so I'll submit a PR to do that. |
Failed again - https://ci.nodejs.org/job/node-test-binary-armv7l/9322/ |
Refs: nodejs#49933 - SKIP instead of mark FLAKY as tests seems to fail builds through left over processe Signed-off-by: Michael Dawson <midawson@redhat.com>
Seems to fail on ubuntu as well - https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_shared_x64/41479/ |
PR-URL: nodejs/node#50259 Refs: nodejs/node#49933 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
PR-URL: nodejs/node#50259 Refs: nodejs/node#49933 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Again - https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos20-64/55713/ logs
This test seems to fail quite often lately |
Test
sequential.test-watch-mode-inspect
Platform
Linux ARMv7
Console output
Build links
Additional information
No response
The text was updated successfully, but these errors were encountered: