Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequential.test-watch-mode-inspect seems flaky #49933

Open
mhdawson opened this issue Sep 28, 2023 · 21 comments
Open

sequential.test-watch-mode-inspect seems flaky #49933

mhdawson opened this issue Sep 28, 2023 · 21 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 28, 2023

Test

sequential.test-watch-mode-inspect

Platform

Linux ARMv7

Console output

Error Message
fail (-15)
Stacktrace
---
duration_ms: 360029.938
exitcode: -15
severity: fail
...

Build links

Additional information

No response

@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 28, 2023
@github-actions github-actions bot added the arm Issues and PRs related to the ARM platform. label Sep 28, 2023
@mhdawson
Copy link
Member Author

Failed on same machine, two builds in a row
test-equinix-ubuntu2004_container-armv7l-1

@mhdawson
Copy link
Member Author

Passed when it ran on test-equinix-ubuntu2204-x64-2 so could be specific to that machine.

Need to track to see if it fails across the machines or not.

@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

Interestingly I see this in the output

not ok 3844 sequential/test-watch-mode-inspect # TODO : Fix flaky test

which seems to say it's a known issue even though I could not find a tracking issue.

@richardlau
Copy link
Member

FWIW the test is already marked flaky

# https://github.com/nodejs/node/issues/44898
test-watch-mode: PASS, FLAKY
test-watch-mode-inspect: PASS, FLAKY

https://ci.nodejs.org/job/node-test-binary-armv7l/7720/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/console has failed because of leftover Node.js processes (which are probably related to the test being timed out):

17:02:09 All tests passed.
17:02:09 ps awwx | grep Release/node | grep -v grep | cat
17:02:09 2212632 ?        Sl     0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 --watch /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
17:02:09 2212638 ?        Sl     0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
17:02:09 make: *** [Makefile:538: test-ci-js] Error 1

@anonrig
Copy link
Member

anonrig commented Oct 17, 2023

It failed on again on ubuntu 22.04 https://ci.nodejs.org/job/node-test-commit-osx-arm/13900/

@anonrig
Copy link
Member

anonrig commented Oct 18, 2023

Seen on node-test-commit-arm-fanned https://ci.nodejs.org/job/node-test-binary-armv7l/8168/

@mhdawson
Copy link
Member Author

I don't see if failing in https://ci.nodejs.org/job/node-test-commit-osx-arm/13900/, that seemed to be a different test test-watch-mode without the inspect part.

nodejs-github-bot pushed a commit that referenced this issue Oct 22, 2023
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this issue Oct 23, 2023
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
PR-URL: nodejs#50259
Refs: nodejs#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this issue Nov 11, 2023
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@mhdawson
Copy link
Member Author

targos pushed a commit that referenced this issue Nov 27, 2023
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@mhdawson
Copy link
Member Author

mhdawson commented Dec 4, 2023

@mhdawson
Copy link
Member Author

mhdawson commented Dec 4, 2023

Not sure why I keep seeing these even though the test is marked as flaky. Looked at the CI jobs and I don't see anything obviously wrong.

@richardlau do you know of any reason off the top of your head a job might not be treating flaky tests as ok?

@richardlau
Copy link
Member

@mhdawson https://ci.nodejs.org/job/node-test-binary-armv7l/9064/RUN_SUBSET=js,nodes=ubuntu2004-armv7l/console failed because:

18:27:41 All tests passed.
18:27:41 ps awwx | grep Release/node | grep -v grep | cat
18:27:41  601756 ?        Sl     0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 --watch /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
18:27:41  601762 ?        Sl     0:00 /home/iojs/build/workspace/node-test-binary-armv7l/out/Release/node --inspect=0 /home/iojs/build/workspace/node-test-binary-armv7l/test/fixtures/watch-mode/inspect.js
18:27:41 make: *** [Makefile:538: test-ci-js] Error 1

"All tests passed" means that the failure was treated as flaky. The problem is that it left behind child processes and the build will fail if any node process are still running after the test runner exits:

node/Makefile

Lines 554 to 559 in 342ddb0

$(info Clean up any leftover processes, error if found.)
ps awwx | grep Release/node | grep -v grep | cat
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
if [ "$${PS_OUT}" ]; then \
echo $${PS_OUT} | xargs kill -9; exit 1; \
fi

@mhdawson
Copy link
Member Author

mhdawson commented Dec 7, 2023

@richardlau, if I get what you are saying is that even though the job out reports this test, that was not the problem, instead it was because child processes were left behind that may/likely have nothing to do with that flaky test right?

@richardlau
Copy link
Member

@mhdawson Yes, although I suspect the leftover processes are from the flaky test which I believe has been timed out.

@mhdawson
Copy link
Member Author

mhdawson commented Dec 7, 2023

@richardlau ok, if we believe they are related to the test then SKIP might be more appropriate right? If so I'll submit a PR to do that.

@mhdawson
Copy link
Member Author

mhdawson added a commit to mhdawson/io.js that referenced this issue Dec 18, 2023
Refs: nodejs#49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
nodejs-github-bot pushed a commit that referenced this issue Dec 22, 2023
Refs: #49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 2, 2024
Refs: #49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Feb 2, 2024

richardlau pushed a commit that referenced this issue Mar 25, 2024
Refs: #49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@jakecastelli
Copy link
Member

Again - https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos20-64/55713/

logs
22:09:53 not ok 4228 sequential/test-watch-mode-inspect # TODO : Fix flaky test
22:09:53   ---
22:09:53   duration_ms: 300129.29800
22:09:53   severity: fail
22:09:53   exitcode: -15
22:09:53   stack: |-
22:09:53     timeout
22:09:53     [test] Connecting to a child Node process
22:09:53     [test] Testing /json/list
22:09:53     TAP version 13
22:09:53     [err] Debugger listening on ws://127.0.0.1:61622/bec85c05-bcf7-4407-86de-720d30c10727
22:09:53     [err] For help, see: https://nodejs.org/en/docs/inspector
22:09:53     [err] 
22:09:53     [err] Debugger attached.
22:09:53     [err] 
22:09:53     [test] Connecting to a child Node process
22:09:53     [test] Testing /json/list
22:09:53     [err] Debugger ending on ws://127.0.0.1:61622/bec85c05-bcf7-4407-86de-720d30c10727
22:09:53     [err] For help, see: https://nodejs.org/en/docs/inspector
22:09:53     [err] 
22:09:53     [out] safe to debug now
22:09:53     [out] 
22:09:53   ...

This test seems to fail quite often lately

@targos
Copy link
Member

targos commented Aug 8, 2024

@aduh95
Copy link
Contributor

aduh95 commented Sep 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

6 participants