Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TransformStream cleanup using "transformer.cancel" #49971

Closed
lucacasonato opened this issue Sep 30, 2023 · 1 comment · Fixed by #50126
Closed

Implement TransformStream cleanup using "transformer.cancel" #49971

lucacasonato opened this issue Sep 30, 2023 · 1 comment · Fixed by #50126
Labels
feature request Issues that request new features to be added to Node.js. web streams

Comments

@lucacasonato
Copy link

The Streams specification has been updated with support for a hook to cleanup a TransformStream on error / abort. See whatwg/streams#1283. WPTs are available: web-platform-tests/wpt#40453
@lucacasonato lucacasonato mentioned this issue Sep 30, 2023
Merged
4 tasks
@debadree25 debadree25 added feature request Issues that request new features to be added to Node.js. web streams labels Sep 30, 2023
@lucacasonato lucacasonato changed the title Implement TransformStream cleanup using "transformer.cleanup" Implement TransformStream cleanup using "transformer.cancel" Sep 30, 2023
@debadree25
Copy link
Member

I am trying to implement this, i am coming across some weird behaviour for the test https://github.com/web-platform-tests/wpt/blob/1267d50de7f8adf06dbddaba00b4d9651ae146a4/streams/transform-streams/errors.any.js#L266 it seems after calling controller.error the writable stream should also error? if so cancelPromise should also throw because writable has entered errored state? or is node's behaviour wrong here?

debadree25 added a commit to debadree25/node that referenced this issue Oct 1, 2023
@debadree25
streams: implement TransformStream cleanup using
040957e 
Fixes: nodejs#49971
debadree25 added a commit to debadree25/node that referenced this issue Oct 10, 2023
@debadree25
streams: implement TransformStream cleanup using
9ce9716 
Fixes: nodejs#49971
debadree25 added a commit to debadree25/node that referenced this issue Oct 10, 2023
@debadree25
streams: implement TransformStream cleanup using "transformer.cancel"
ea11c1e 
Fixes: nodejs#49971
@debadree25 debadree25 mentioned this issue Oct 10, 2023
Merged
debadree25 added a commit to debadree25/node that referenced this issue Oct 23, 2023
@debadree25
streams: implement TransformStream cleanup using "transformer.cancel"
aac37a2 
Fixes: nodejs#49971
debadree25 added a commit to debadree25/node that referenced this issue Oct 23, 2023
@debadree25
stream: implement TransformStream cleanup using "transformer.cancel"
de4983a 
Fixes: nodejs#49971
debadree25 added a commit to debadree25/node that referenced this issue Nov 26, 2023
@debadree25
stream: implement TransformStream cleanup using "transformer.cancel"
ee89ba1 
Fixes: nodejs#49971
nodejs-github-bot pushed a commit that referenced this issue Dec 15, 2023
@debadree25
stream: implement TransformStream cleanup using "transformer.cancel"
7a2a4d0 
Fixes: #49971
PR-URL: #50126
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this issue Dec 15, 2023
@debadree25 @RafaelGSS
stream: implement TransformStream cleanup using "transformer.cancel"
71acd36 
Fixes: #49971
PR-URL: #50126
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MattiasBuelens pushed a commit to MattiasBuelens/node that referenced this issue May 1, 2024
@debadree25 @MattiasBuelens
stream: implement TransformStream cleanup using "transformer.cancel"
10a0718 
Fixes: nodejs#49971
PR-URL: nodejs#50126
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MattiasBuelens MattiasBuelens mentioned this issue May 1, 2024
Closed
MattiasBuelens pushed a commit to MattiasBuelens/node that referenced this issue May 1, 2024
@debadree25 @MattiasBuelens
stream: implement TransformStream cleanup using "transformer.cancel"
d36fbc3 
Fixes: nodejs#49971
PR-URL: nodejs#50126
Backport-PR-URL: nodejs#52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito pushed a commit that referenced this issue May 16, 2024
@debadree25 @marco-ippolito
stream: implement TransformStream cleanup using "transformer.cancel"
3dd96f1 
Fixes: #49971
PR-URL: #50126
Backport-PR-URL: #52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

streams: implement TransformStream cleanup using "transformer.cancel" debadree25/node
2 participants
@lucacasonato @debadree25