Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel.test-runner-watch-mode is flaky #49985

Closed
anonrig opened this issue Oct 1, 2023 · 4 comments
Closed

parallel.test-runner-watch-mode is flaky #49985

anonrig opened this issue Oct 1, 2023 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem. windows Issues and PRs related to the Windows platform.

Comments

@anonrig
Copy link
Member

anonrig commented Oct 1, 2023 •
edited
Loading

Test

parallel.test-runner-watch-mode

Platform

Windows

Console output

not ok 751 parallel/test-runner-watch-mode # TODO : Fix flaky test
  ---
  duration_ms: 8645.08900
  severity: flaky
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: test runner watch mode
        # Subtest: should run tests repeatedly
        ok 1 - should run tests repeatedly
          ---
          duration_ms: 2693.0066
          ...
        # Subtest: should run tests with dependency repeatedly
        ok 2 - should run tests with dependency repeatedly
          ---
          duration_ms: 1796.3552
          ...
        # Subtest: should run tests with ESM dependency
        ok 3 - should run tests with ESM dependency
          ---
          duration_ms: 1799.0633
          ...
        # Subtest: should support running tests without a file
        ok 4 - should support running tests without a file
          ---
          duration_ms: 1775.4925
          ...
        1..4
    ok 1 - test runner watch mode
      ---
      duration_ms: 8067.7592
      type: 'suite'
      ...
    1..1
    # tests 4
    # suites 1
    # pass 4
    # fail 0
    # cancelled 0
    # skipped 0
    # todo 0
    # duration_ms 8089.987
    Can't clean tmpdir: d:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.647
    Files blocking: [ 'dependency.js', 'dependency.mjs', 'test.js' ]
    
    d:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:69
        throw e;
        ^
    
    Error: EBUSY: resource busy or locked, rmdir '\\?\d:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.647'
        at rmdirSync (node:fs:1231:10)
        at _rmdirSync (node:internal/fs/rimraf:235:5)
        at rimrafSync (node:internal/fs/rimraf:193:7)
        at Object.rmSync (node:fs:1280:10)
        at rmSync (d:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:20:8)
        at onexit (d:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:54:5)
        at process.<anonymous> (d:\workspace\node-test-binary-windows-js-suites\node\test\common\tmpdir.js:43:14)
        at process.emit (node:events:527:35) {
      errno: -4082,
      syscall: 'rmdir',
      code: 'EBUSY',
      path: '\\\\?\\d:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\.tmp.647'
    }
    
    Node.js v21.0.0-pre
  ...

Build links

Additional information

No response
@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem. windows Issues and PRs related to the Windows platform. labels Oct 1, 2023
@benjamingr
Copy link
Member

@MoLow

@MoLow MoLow mentioned this issue Oct 1, 2023
Closed
@anonrig anonrig mentioned this issue Oct 17, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Oct 18, 2023
@anonrig
test: set test-runner-watch-mode as flaky
aa8282e 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@cjihrig
Copy link
Contributor

cjihrig commented Oct 21, 2023

Duplicate of #49605?

@anonrig anonrig closed this as completed Oct 21, 2023
targos pushed a commit that referenced this issue Oct 23, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
8efb75f 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@anonrig @alexfernandez
test: set test-runner-watch-mode as flaky
0102327 
PR-URL: nodejs#50221
Refs: nodejs#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos pushed a commit that referenced this issue Nov 11, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
c2c2506 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos pushed a commit that referenced this issue Nov 27, 2023
@anonrig @targos
test: set test-runner-watch-mode as flaky
5953a25 
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
dccc650 
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
530add0 
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@anonrig
Copy link
Member Author

anonrig commented Sep 6, 2024

This is still flaky https://ci.nodejs.org/job/node-test-binary-windows-js-suites/29834/

@anonrig anonrig reopened this Sep 6, 2024
@lpinca
Copy link
Member

lpinca commented Sep 6, 2024

Duplicate of #49605.

@lpinca lpinca closed this as completed Sep 6, 2024
@lpinca lpinca mentioned this issue Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake test-runner-watch-mode MoLow/node
4 participants
@benjamingr @lpinca @anonrig @cjihrig