Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel.test-worker-nearheaplimit-deadlock is flaky #50220

Closed
anonrig opened this issue Oct 17, 2023 · 2 comments · Fixed by #50238
Closed

parallel.test-worker-nearheaplimit-deadlock is flaky #50220

anonrig opened this issue Oct 17, 2023 · 2 comments · Fixed by #50238
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@anonrig
Copy link
Member

anonrig commented Oct 17, 2023

Test

parallel.test-worker-nearheaplimit-deadlock

Platform

Windows

Console output

not ok 871 parallel/test-worker-nearheaplimit-deadlock
  ---
  duration_ms: 390.65800
  severity: fail
  exitcode: 134
  stack: |-
    
    <--- Last few GCs --->
    
    [4284:0C1A7400]       65 ms: Mark-Compact 1.5 (3.9) -> 1.5 (3.9) MB, 2.52 / 0.00 ms  (average mu = 0.660, current mu = 0.010) background allocation failure; GC in old space requested
    [4284:0C1A7400]       68 ms: Mark-Compact 1.5 (3.9) -> 1.5 (3.9) MB, 2.67 / 0.00 ms  (average mu = 0.536, current mu = 0.127) background allocation failure; GC in old space requested
    
    
    <--- JS stacktrace --->
    
    FATAL ERROR: LocalHeap: allocation failed Allocation failed - JavaScript heap out of memory
  ...

Build links

Additional information

No response
@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 17, 2023
@github-actions github-actions bot added the windows Issues and PRs related to the Windows platform. label Oct 17, 2023
StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Oct 18, 2023
@StefanStojanovic
test: set test-worker-nearheaplimit-deadlock flaky
423f2c1 
The test is only flaky on x86 Windows.

Fixes: nodejs#50220
@StefanStojanovic StefanStojanovic mentioned this issue Oct 18, 2023
Merged
@anonrig anonrig reopened this Oct 18, 2023
@legendecas legendecas mentioned this issue Oct 18, 2023
Closed
@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Oct 19, 2023 •
edited
Loading

@anonrig, just to check - you reopened this because the PR didn't fix it, or as a precaution measurement.

Edit: I see you've encountered it again in #50261 and I know why. In my original PR I put $arch==x86 although it should be $arch==ia32. I've opened a new PR fixing this.

@StefanStojanovic StefanStojanovic mentioned this issue Oct 19, 2023
Closed
@targos
Copy link
Member

targos commented Oct 19, 2023

Setting the test as flaky doesn't fix the flakyness, so the issue should stay open anyway

targos pushed a commit that referenced this issue Oct 23, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
a38d131 
The test is only flaky on x86 Windows.

Fixes: #50220
PR-URL: #50238
Refs: #49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@StefanStojanovic @alexfernandez
test: set test-worker-nearheaplimit-deadlock flaky
56091e2 
The test is only flaky on x86 Windows.

Fixes: nodejs#50220
PR-URL: nodejs#50238
Refs: nodejs#49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this issue Nov 11, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
228c87f 
The test is only flaky on x86 Windows.

Fixes: #50220
PR-URL: #50238
Refs: #49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this issue Nov 27, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
54f3d87 
The test is only flaky on x86 Windows.

Fixes: #50220
PR-URL: #50238
Refs: #49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: set test-worker-nearheaplimit-deadlock flaky
c16f293 
The test is only flaky on x86 Windows.

Fixes: nodejs/node#50220
PR-URL: nodejs/node#50238
Refs: nodejs/node#49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: set test-worker-nearheaplimit-deadlock flaky
4c28669 
The test is only flaky on x86 Windows.

Fixes: nodejs/node#50220
PR-URL: nodejs/node#50238
Refs: nodejs/node#49962
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: set test-worker-nearheaplimit-deadlock flaky JaneaSystems/node
3 participants
@anonrig @targos @StefanStojanovic