[WebSocket] Add CloseEvent
#50275
Comments
regseb
added
the
feature request
|
There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the
never-stale
|
|
|
|
@nodejs/undici |
mcollina
added
the
good first issue
|
This is a actually easy to add. |
|
once undici is updated it will be |
|
Didnt I merge your PR @KhafraDev So it should be already part of the next release ;) |
|
I was digging around this issue in hopes that it could be my first open source contribution. I forked the repo and cloned it on my local. Haven't really gone further than that. The IDE configs and understanding the build process is a work in progress. After spending a good amount of time, I am having an understanding that the issue is related to code in the dep: undici. The issue suggested to either fix it there or add that event directly in here. The fix is merged in the dep repo 5 days ago. Am I correct? Is there anything still required here in this repo? I mean as per my understanding undici implements websocket and its defined on the globalThis and if CloseEvent is now exported from there (thanks to KhafraDev), then it should be available through globalThis.WebSocket. I can even see the CloseEvent |
|
Undici has to release a new version. Then nodejs will update the dependency. And then you have to rebase your PR. |
This PR adds `CloseEvent` as a global, which can be disabled via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: nodejs#50275
This PR adds `CloseEvent` as a global, which can be disabled via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: nodejs#50275
This PR adds `CloseEvent` as a global, which can be disabled
via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: nodejs#50275
This PR adds `CloseEvent` as a global, which can be disabled
via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: #50275
PR-URL: #53355
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This PR adds `CloseEvent` as a global, which can be disabled
via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: nodejs#50275
PR-URL: nodejs#53355
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This PR adds `CloseEvent` as a global, which can be disabled
via the --no-experimental-websocket flag.
```js
const ws = new WebSocket('...')
ws.addEventListener('close', (event) => {
assert(event instanceof CloseEvent)
})
```
Fixes: nodejs#50275
PR-URL: nodejs#53355
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
What is the problem this feature will solve?
In Node.js v21 with
--experimental-websocket, theCloseEventclass isn't defined. This event is sent to clients using WebSockets when the connection is closed.What is the feature you are proposing to solve the problem?
Add the
CloseEventclass in the global scope (behind--experimental-websocketflags). I found it in undici but it isn't exported. Or add theCloseEventclass next toMessageEvent(directly in Node.js).What alternatives have you considered?
No response
Related issues
CloseEvent#46880ErrorEventandCloseEventon global scope undici#2084The text was updated successfully, but these errors were encountered: