Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--jitless and --frozen-intrinsics options can not be combined #51232

Closed
timkuijsten opened this issue Dec 20, 2023 · 1 comment · Fixed by #51248
Closed

--jitless and --frozen-intrinsics options can not be combined #51232

timkuijsten opened this issue Dec 20, 2023 · 1 comment · Fixed by #51248

Comments

@timkuijsten
Copy link
Contributor

timkuijsten commented Dec 20, 2023

Version

v18.18.0

Platform

Linux 6.2.0-37-generic #38~22.04.1-Ubuntu SMP

Subsystem

lib

What steps will reproduce the bug?

echo 'console.log("hello")' | node --jitless --frozen-intrinsics
Warning: disabling flag --expose_wasm due to conflicting flags
node:internal/freeze_intrinsics:224
    WebAssembly.Module.prototype,
                ^

TypeError: Cannot read properties of undefined (reading 'Module')
    at module.exports (node:internal/freeze_intrinsics:224:17)
    at initializeFrozenIntrinsics (node:internal/process/pre_execution:598:42)
    at setupUserModules (node:internal/process/pre_execution:132:3)
    at prepareExecution (node:internal/process/pre_execution:113:5)
    at prepareMainThreadExecution (node:internal/process/pre_execution:40:3)
    at node:internal/main/eval_stdin:18:1

Node.js v18.18.0

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

That --jitless and --frozen-intrinsics are not mutually exclusive.

What do you see instead?

node:internal/freeze_intrinsics:224
    WebAssembly.Module.prototype,
                ^

TypeError: Cannot read properties of undefined (reading 'Module')
    at module.exports (node:internal/freeze_intrinsics:224:17)

Additional information

It looks like the problem still exists in the latest node:
https://github.com/nodejs/node/blob/v21.5.0/lib/internal/freeze_intrinsics.js#L223

@bakkot
Copy link

bakkot commented Dec 20, 2023

Should be trivial to fix this the same way Intl is handled.

nodejs-github-bot pushed a commit that referenced this issue Dec 23, 2023
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jan 2, 2024
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this issue Mar 25, 2024
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants