Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parallel/test-fs-watch-recursive-delete fails on IBM i #52640

Closed
abmusse opened this issue Apr 22, 2024 · 1 comment · Fixed by #52645
Closed

test: parallel/test-fs-watch-recursive-delete fails on IBM i #52640

abmusse opened this issue Apr 22, 2024 · 1 comment · Fixed by #52645
Labels
ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.

Comments

@abmusse
Copy link
Contributor

abmusse commented Apr 22, 2024

Ref: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/lastBuild/consoleFull

08:14:17 not ok 1263 parallel/test-fs-watch-recursive-delete
08:14:17   ---
08:14:17   duration_ms: 2243.99100
08:14:17   severity: fail
08:14:17   exitcode: 1
08:14:17   stack: |-
08:14:17     Mismatched <anonymous> function calls. Expected at least 1, actual 0.
08:14:17         at Proxy.mustCallAtLeast (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/test/common/index.js:439:10)
08:14:17         at Object.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/test/parallel/test-fs-watch-recursive-delete.js:18:29)
08:14:17         at Module._compile (node:internal/modules/cjs/loader:1476:14)
08:14:17         at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
08:14:17         at Module.load (node:internal/modules/cjs/loader:1288:32)
08:14:17         at Module._load (node:internal/modules/cjs/loader:1104:12)
08:14:17         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
08:14:17         at node:internal/main/run_main_module:30:49
08:14:17   ...

fs.watch is not supported on IBM i therefore it makes sense that this test case fails.

const watcher = fs.watch(toWatch, { recursive: true }, onFileUpdate);

We should skip this test on IBM i like we do for the other fs.watch test cases.

if (common.isIBMi)
common.skip('IBMi does not support `fs.watch()`');

@VoltrexKeyva VoltrexKeyva added test Issues and PRs related to the tests. ibm i Issues and PRs related to the IBM i platform. labels Apr 22, 2024
@MoLow MoLow linked a pull request Apr 24, 2024 that will close this issue
nodejs-github-bot pushed a commit that referenced this issue Apr 24, 2024
PR-URL: #52645
Refs: #52640
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@abmusse
Copy link
Contributor Author

abmusse commented Apr 24, 2024

FYI The build today was back to green: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/lastBuild/consoleFull 🎉

aduh95 pushed a commit that referenced this issue Apr 29, 2024
PR-URL: #52645
Refs: #52640
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this issue May 2, 2024
PR-URL: #52645
Refs: #52640
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this issue May 3, 2024
PR-URL: #52645
Refs: #52640
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
PR-URL: nodejs#52645
Refs: nodejs#52640
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants