Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v22.0.0 breaks --v8-lite-mode build missing action for js-to-wasm-tq-csa.cc #52710

Closed
davidfiala opened this issue Apr 26, 2024 · 2 comments · Fixed by #52725
Closed

v22.0.0 breaks --v8-lite-mode build missing action for js-to-wasm-tq-csa.cc #52710

davidfiala opened this issue Apr 26, 2024 · 2 comments · Fixed by #52725
Labels
build Issues and PRs related to build files or the CI.

Comments

@davidfiala
Copy link

Version

22.0.0

Platform

Linux x86_64 Alpine 3.19.1

Subsystem

No response

What steps will reproduce the bug?

  • Using x86_64 Alpine 3.19.1 checkout nodejs tag v22.0.0
  • Configure with: ./configure --ninja --v8-lite-mode
  • Attempt compilation with: ninja -C out/Release node
  • Observe error: ninja: file is missing and not created by any action: 'gen/torque-generated/src/builtins/js-to-wasm-tq-csa.cc'

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

# ./configure --ninja --v8-lite-mode && ninja -C out/Release node
Node.js configure: Found Python 3.11.9...
INFO: configure completed successfully
ninja: entering directory 'out/Release'
ninja: file is missing and not created by any action: 'gen/torque-generated/src/builtins/js-to-wasm-tq-csa.cc'

Additional information

Last seen working on v21.7.3 commit in git. Seems exclusive to v22.0.0 tag.
@davidfiala
Copy link
Author

I'm going to guess it is related to 4e278f0 where perhaps that target isn't being deselected in v8 lite mode.

PR and Bug related:

PR on not including wasm in lite mode:

@VoltrexKeyva VoltrexKeyva added the build Issues and PRs related to build files or the CI. label Apr 26, 2024
@daeyeon daeyeon mentioned this issue Apr 27, 2024
Merged
@daeyeon
Copy link
Member

daeyeon commented Apr 27, 2024

Thank you for the detailed report. I opened a PR. PTAL.

nodejs-github-bot pushed a commit that referenced this issue Jun 3, 2024
@daeyeon
build: fix --v8-lite-mode build
58711c2 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #52725
Fixes: #52710
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Jun 3, 2024
@daeyeon @targos
build: fix --v8-lite-mode build
0976439 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #52725
Fixes: #52710
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this issue Jun 20, 2024
@daeyeon @sophoniie
build: fix --v8-lite-mode build
576e390 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#52725
Fixes: nodejs#52710
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@daeyeon @bmeck
build: fix --v8-lite-mode build
28eddd8 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#52725
Fixes: nodejs#52710
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix --v8-lite-mode build daeyeon/node
3 participants
@daeyeon @davidfiala @VoltrexKeyva