-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This repositories devcontainer setup deletes all your other devcontainers #53129
Comments
This is bad practice, the initializeCommand runs on your host machine. From containers.dev documentation
I don't know the specific reason why they do this but generally is due to the need to avoid polluting the docker system with new builds every time a new change is deployed. Nevertheless, this will undoubtedly destroy entirely all your other containers :/ Edited to fix a typo. |
CC @bnb (Added the file) |
PR-URL: nodejs#53137 Fixes: nodejs#53129 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#53137 Fixes: nodejs#53129 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: James M Snell <jasnell@gmail.com>
If you clone this repository in a devcontainer, it will delete all your other devcontainers.
This is extremely bad, as it ruins your development environment. This may not be as problematic for people who use this repository often, but it is for the casual contributor who uses devcontainer.
I don't know why
docker system prune -f -a"
was added asinitializeCommand
in #40825, but I think it should be removed.(Sorry for not using an issue template. This is not related to node itself, but rather to its repository)
The text was updated successfully, but these errors were encountered: