Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,tool: parse standard error types automatically? #5325

Closed
estliberitas opened this issue Feb 19, 2016 · 2 comments
Closed

doc,tool: parse standard error types automatically? #5325

estliberitas opened this issue Feb 19, 2016 · 2 comments
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js.

Comments

@estliberitas
Copy link
Contributor

Hi guys. I decided to move discussion here from #5322.

Currently errors.markdown has some unresolved links to standard errors description on MDN. Below there is a list of described errors:

  • EvalError
  • RangeError
  • ReferenceError
  • SyntaxError
  • TypeError
  • URIError

And also doc tool has type parser with list of global types.

Maybe add these errors to global types list, so it would be possible just use {SyntaxError}? Also this would save some bytes.
@mscdex mscdex added doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. labels Feb 19, 2016
@Fishrock123
Copy link
Contributor

Sounds good to me. @estliberitas want to make a PR?

@estliberitas
Copy link
Contributor Author

Yep, will do.

@estliberitas estliberitas mentioned this issue Feb 20, 2016
Closed
MylesBorins pushed a commit that referenced this issue Apr 19, 2016
@estliberitas
tools,doc: parse types in braces everywhere
3a6d776 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
07484a9 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
2567f2d 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
d516412 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 21, 2016
@estliberitas @MylesBorins
tools,doc: parse types in braces everywhere
0658632 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this issue Apr 25, 2016
@estliberitas @joelostrowski
tools,doc: parse types in braces everywhere
2620716 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: nodejs#5325.
PR-URL: nodejs#5329
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this issue Apr 26, 2016
@estliberitas @jasnell
tools,doc: parse types in braces everywhere
df9e6fb 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 3, 2016
@estliberitas
tools,doc: parse types in braces everywhere
aeea832 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 6, 2016
@estliberitas
tools,doc: parse types in braces everywhere
ab7f3dd 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 18, 2016
@estliberitas
tools,doc: parse types in braces everywhere
c893cd3 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @estliberitas @Fishrock123