-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation fault when using inspector on experimental permission enabled process #53385
Comments
I don't know how to debug C++ code, but here's some info:
|
@nodejs/inspector |
I confirmed the problem, will look into it, assigning to myself. |
Oh, can't assign, no longer a contributor :) Feel free to assign to me. |
I have made a PR to fix it. |
I think this is because setting |
Kind reminder that collaborators removed due to inactivity are more than welcome to come back and many have done so in the past :) |
@RafaelGSS According to RafaelGSS@34d92ed, the inspector feature is restricted when the permission model is enabled, and there is no flag to enable it, correct? |
That's correct. We haven't included a |
There used to be discussions with some cloud providers about optionally restricting some Inspector domains to make some operations impossible. E.g. we could disable Debugger/Runtime but leave Tracing/Profile. It should be fairly doable from a technical point of view, though I expect there would be a game of wack-a-mole with some functionality still providing too much power... Main concern was the worry that most frontends would not expect the domains being unavailable, making this functionality mostly useless. Feel free to initiate a discussion if there's more interest in this. |
You can not use inspector when run on permission mode. |
PR-URL: nodejs#53389 Fixes: nodejs#53385 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
PR-URL: nodejs#53389 Fixes: nodejs#53385 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Version
v22.2.0
Platform
Linux AS-ZISU 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
The content of the script does not matter - even an empty script will work.
How often does it reproduce? Is there a required condition?
No condition required. Node v22.2.0 will crash everytime when
--experimental-permission
is combined with--inspect-brk
.What is the expected behavior? Why is that the expected behavior?
The inspector should work and do not segfault.
What do you see instead?
The node process crash because of segfault. Also, no stack trace is printed.
Additional information
The experimental process-based permission model have unexpected side effects with inspector, which is not well-documented.
When enabled,
--inspect
and SIGUSR1 both wouldn't work. Should this be a feature, or another bug?The text was updated successfully, but these errors were encountered: