Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.assert throwing behaviour and Console object #5340

Closed
qfox opened this issue Feb 20, 2016 · 4 comments
Closed

console.assert throwing behaviour and Console object #5340

qfox opened this issue Feb 20, 2016 · 4 comments
Labels
console Issues and PRs related to the console subsystem.

Comments

@qfox
Copy link

qfox commented Feb 20, 2016

At the moment we have DeveloperToolsWG document about Console object (console.assert) and it's quitely strange to have different behaviour for console.assert in node environment.

Method console.assert was introduced in the early state of node development in 2010 via process.assert: 8e9f59a.

But now, when we very close to have document for Console object... What you think about fix console.assert behaviour in the next major release to stop throwing? And even fix all Console object methods?
@evanlucas
Copy link
Contributor

It would be a breaking change (which isn't necessarily a bad thing). If this is something you feel strongly about, the best course of action would be to submit a pull request. Thanks!

@vkurchatkin vkurchatkin added the console Issues and PRs related to the console subsystem. label Feb 20, 2016
@vkurchatkin
Copy link
Contributor

I wouldn't object this change, but in general there is no goal (yet, at least) to make node's APIs fully compatible with web counterparts

@qfox
Copy link
Author

qfox commented Feb 20, 2016

@vkurchatkin Yeah, that's why I've come. ;-(

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

A PR would be worthwhile. No guarantees it would land but it's worth opening the discussion.

@jasnell jasnell mentioned this issue Apr 12, 2016
Closed
2 tasks
jasnell added a commit to jasnell/node that referenced this issue Apr 13, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
4c5a6c3 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" nodejs#5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: nodejs#5340
MylesBorins pushed a commit that referenced this issue Apr 19, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
8fd0bc0 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
2190fcb 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
46f774f 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
3bc3152 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue Apr 21, 2016
@jasnell @MylesBorins
doc: explain differences in console.assert between node and browsers
5c4395b 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
joelostrowski pushed a commit to joelostrowski/node that referenced this issue Apr 25, 2016
@jasnell @joelostrowski
doc: explain differences in console.assert between node and browsers
070acff 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" nodejs#5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: nodejs#5340
PR-URL: nodejs#6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
jasnell added a commit that referenced this issue Apr 26, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
ebf20ed 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue May 3, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
ad91bed 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue May 6, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
909390e 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
MylesBorins pushed a commit that referenced this issue May 18, 2016
@jasnell
doc: explain differences in console.assert between node and browsers
4ec9ae8 
Provide an example for implementing browser like behavior for console.assert.

This "fixes" #5340 by providing an
alternative to changing Node.js' implemented behavior. Instead, we
document the differences and show how to work around them if
browser like semantics are desired.

Fixes: #5340
PR-URL: #6169
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Jeff Harris <@techjeffharris>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: explain differences in console.assert between node and browsers jasnell/node
4 participants
@jasnell @qfox @evanlucas @vkurchatkin