Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path.relative() result changed in v5.7.0 #5383

Closed
4kochi opened this issue Feb 23, 2016 · 2 comments
Closed

path.relative() result changed in v5.7.0 #5383

4kochi opened this issue Feb 23, 2016 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. path Issues and PRs related to the path subsystem.
Milestone
5.7.1

Comments

@4kochi
Copy link

4kochi commented Feb 23, 2016

  • Version: v5.7.0
  • Platform: Darwin pitti.local 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64
  • Subsystem: path

Here is the output:

pitti:~ master$ node -v
v5.6.0
pitti:~ master$ node
> path.relative('/Users/a/web/b/test/mails', '/Users/a/web/b')
'../..'
> 
(To exit, press ^C again or type .exit)
> 
pitti:~ master$ node -v
v5.7.0
pitti:~ master$ node
> path.relative('/Users/a/web/b/test/mails', '/Users/a/web/b')
'../../../b'
>
@evanlucas
Copy link
Contributor

/cc @mscdex

@mscdex mscdex added the path Issues and PRs related to the path subsystem. label Feb 23, 2016
mscdex added a commit to mscdex/io.js that referenced this issue Feb 23, 2016
@mscdex
path: fix verbose relative() output
6c86aa7 
Fixes: nodejs#5383
@mscdex mscdex mentioned this issue Feb 23, 2016
Closed
4 tasks
@m99coder
Copy link

Related gruntjs/grunt-contrib-clean#85

@geek geek mentioned this issue Feb 23, 2016
Closed
@vladikoff vladikoff mentioned this issue Feb 23, 2016
Closed
@Fishrock123 Fishrock123 modified the milestone: v5.7.1 Feb 23, 2016
@Fishrock123 Fishrock123 mentioned this issue Feb 23, 2016
Closed
3 tasks
@jacargentina jacargentina mentioned this issue Feb 25, 2016
Closed
@rvagg rvagg mentioned this issue Feb 26, 2016
Closed
@silverwind silverwind added the confirmed-bug Issues with confirmed bugs. label Feb 27, 2016
rvagg pushed a commit that referenced this issue Feb 28, 2016
@mscdex @rvagg
path: fix verbose relative() output
30cec18 
Fixes: #5383
PR-URL: #5389
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@eruizdechavez eruizdechavez mentioned this issue Feb 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
5.7.1
Development

Successfully merging a pull request may close this issue.

path: fix verbose relative() output mscdex/io.js
6 participants
@mscdex @silverwind @evanlucas @Fishrock123 @4kochi @m99coder