Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--heap-prof is not allowed in NODE_OPTIONS #54257

Closed
himself65 opened this issue Aug 7, 2024 · 4 comments · Fixed by #54259
Closed

--heap-prof is not allowed in NODE_OPTIONS #54257

himself65 opened this issue Aug 7, 2024 · 4 comments · Fixed by #54259
Assignees
@juanarbol
Labels
cli Issues and PRs related to the Node.js command line interface. confirmed-bug Issues with confirmed bugs.

Comments

@himself65
Copy link
Member

himself65 commented Aug 7, 2024 •
edited
Loading

Version

20.15.1

Platform

GitHub Action ubuntu-latest

Subsystem

No response

What steps will reproduce the bug?

> NODE_OPTIONS="--heap-prof" node ./custom-server.mjs
node: --heap-prof is not allowed in NODE_OPTIONS

How often does it reproduce? Is there a required condition?

everytimeevery time

What is the expected behavior? Why is that the expected behavior?

should allow pass heap-prof https://github.com/nodejs/node/pull/17600Should

What do you see instead?

error

Additional information

No response
@himself65
Copy link
Member Author

himself65 commented Aug 7, 2024 •
edited
Loading

I saw it's only allowed on Linux, but I was using it on Github CI and it's ubuntu-latest, still error

image

@juanarbol
Copy link
Member

working on this

juanarbol added a commit to juanarbol/node that referenced this issue Aug 7, 2024
@juanarbol
cli: add --heap-proof flag available to NODE_OPTIONS
994c76a 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol juanarbol mentioned this issue Aug 7, 2024
Merged
@himself65
Copy link
Member Author

working on this

You are so fast! Thanks a lot!

juanarbol added a commit to juanarbol/node that referenced this issue Aug 7, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
ca3dbaa 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol added a commit to juanarbol/node that referenced this issue Aug 7, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
2ab666c 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@RedYetiDev RedYetiDev added the cli Issues and PRs related to the Node.js command line interface. label Aug 8, 2024
@RedYetiDev
Copy link
Member

I've assigned @juanarbol, as they have opened a PR to resolve this issue. Because this is a simple fix, I don't want newcomers to come accross this issue thinking they can solve it when it's already been solved. Feel free to unassign.

@himself65 himself65 added the confirmed-bug Issues with confirmed bugs. label Aug 8, 2024
juanarbol added a commit to juanarbol/node that referenced this issue Aug 8, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
0a6c1de 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol added a commit to juanarbol/node that referenced this issue Oct 14, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
0a28ac5 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol added a commit to juanarbol/node that referenced this issue Oct 14, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
86cd89b 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs-github-bot pushed a commit that referenced this issue Oct 20, 2024
@juanarbol
cli: add --heap-prof flag available to NODE_OPTIONS
78b72ca 
Fixes: #54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #54259
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this issue Oct 23, 2024
@juanarbol @aduh95
cli: add --heap-prof flag available to NODE_OPTIONS
52da293 
Fixes: #54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #54259
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@juanarbol @louwers
cli: add --heap-prof flag available to NODE_OPTIONS
9fc8e0c 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: nodejs#54259
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@juanarbol @tpoisseau
cli: add --heap-prof flag available to NODE_OPTIONS
bec33eb 
Fixes: nodejs#54257
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: nodejs#54259
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanarbol juanarbol

Labels
cli Issues and PRs related to the Node.js command line interface. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: add --heap-prof flag available to NODE_OPTIONS juanarbol/node
3 participants
@himself65 @juanarbol @RedYetiDev