SWC + next.js + Node.js v22.7

[RaenonX]

Version

v22.7

Platform

Microsoft Windows NT 10.0.22631.0 x64

Subsystem

No response

What steps will reproduce the bug?

1. Create a next.js app
2. Run next dev
3. (Failed)

How often does it reproduce? Is there a required condition?

Deterministic (everytime).

What is the expected behavior? Why is that the expected behavior?

No error.

What do you see instead?

For others: vercel/next.js#69150 (the actual repo that I realized it's 22.7 release breaking it).

For myself, my CI starts deterministically failing on Aug. 21 (22.7 release date), and the error (One of the failed CI) is always the same of saying "invalid unicode code point."

Additional information

No response

[avivkeller]

Hi! Could you provide a minimal reproduction?

[ViggoV]

Hi! Could you provide a minimal reproduction?

There's also a few replicable examples here: vercel/next.js#69263

[avivkeller]

v22.8.0 is releasing soon with patches for a few buffer issues, so if this is related, that may fix it.

[bernaferrari]

This completely breaks NextJS for me. I think you should check if 22.8 fixes it, because it is a fairly big problem.

[avivkeller]

This completely breaks NextJS for me. I think you should check if 22.8 fixes it, because it is a fairly big problem.

If you'd like to test the buffer patches, their PRs are #54526, #54524, and #54565

[avivkeller]

FWIW, Regarding whether this is a buffer issue or not, I've confirmed it is. looking at the offending code,
It's calling:

bindings.minify(toBuffer(src), toBuffer(options ?? {}));

Reference A: https://www.npmjs.com/package/next?activeTab=code (Line 814)
Reference B: https://github.com/swc-project/swc/blob/d068a63ba218a0884de5cbd10764f3f6f652bc5c/packages/core/src/index.ts#L66

[avivkeller]

I think this is a duplicate of #54521, as the buffer isn't returning what it is expected to, which is what that issue is discussing. WDYT @ronag

[RaenonX]

Sorry was enjoying my weekend, but good to know that it's possibly fix at v22.8. I'll wait and see if v22.8 fixes this! (I assume no repro is needed?)