Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --quiet from eslint invocation #5516

Closed
Trott opened this issue Mar 1, 2016 · 2 comments
Closed

Remove --quiet from eslint invocation #5516

Trott opened this issue Mar 1, 2016 · 2 comments
Labels
tools Issues and PRs related to the tools directory.

Comments

@Trott
Copy link
Member

Trott commented Mar 1, 2016

In Makefile and vcbuild.bat, eslint is invoked with the --quiet flag. That flag causes eslint to only report lint errors and not lint warnings. This is unnecessary as all our rules are configured to report as errors. None of the rules are configured to report as warnings. The flag can be removed.
@Trott Trott added good first issue Issues that are suitable for first-time contributors. tools Issues and PRs related to the tools directory. labels Mar 1, 2016
@firedfox firedfox mentioned this issue Mar 2, 2016
Closed
4 tasks
@zdebyman zdebyman mentioned this issue Mar 2, 2016
Closed
@Trott Trott removed the good first issue Issues that are suitable for first-time contributors. label Mar 2, 2016
@Trott
Copy link
Member Author

Trott commented Mar 2, 2016

Since we have a PR for this in that is very likely to land and already had one duplicate submission from someone else, I've removed the good first contribution tag to hopefully not frustrate others who may be looking for their first commit to the project.

@silverwind
Copy link
Contributor

Fixed by 9beb36a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: remove --quiet from eslint invocation firedfox/node
2 participants
@silverwind @Trott