Removed --quiet from eslint invocation #5520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this PR, however this is a duplicate of #5519. |
mscdex
added
the
duplicate
|
Hi, @zdebyman! Thank you for taking the time to do this. It does appear that someone beat you to it. I'll go remove the If this were being reviewed:
I hope to see other contributions from you in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed --quiet flag from Makefile and vcbuild. That flag causes eslint to only report lint errors and not lint warnings. This is unnecessary as all rules are configured to report as errors. None of the rules are configured to report as warnings.
fixes#5520