Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal.add/removeEventListener('abort', fn) is slow #55311

Closed
ronag opened this issue Oct 8, 2024 · 1 comment · Fixed by #55312
Closed

signal.add/removeEventListener('abort', fn) is slow #55311

ronag opened this issue Oct 8, 2024 · 1 comment · Fixed by #55312
Labels
events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js.

Comments

@ronag
Copy link
Member

ronag commented Oct 8, 2024

Just did a profile of a service in production and noticed that 25% of cpu time goes to add/remove abort listeners. Using signals for async logic doesn't seem to be a very performat solution.

Is there anything we can do to improve this?
@ronag
Copy link
Member Author

ronag commented Oct 8, 2024

@anonrig @benjamingr

@ronag ronag mentioned this issue Oct 8, 2024
Merged
@RedYetiDev RedYetiDev added events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js. labels Oct 8, 2024
nodejs-github-bot pushed a commit that referenced this issue Oct 14, 2024
@ronag
events: optimize EventTarget.addEventListener
488ce99 
PR-URL: #55312
Fixes: #55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this issue Oct 19, 2024
@ronag @aduh95
events: optimize EventTarget.addEventListener
8ceefeb 
PR-URL: #55312
Fixes: #55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@ronag @louwers
events: optimize EventTarget.addEventListener
15b5fe8 
PR-URL: nodejs#55312
Fixes: nodejs#55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@ronag @tpoisseau
events: optimize EventTarget.addEventListener
5b71497 
PR-URL: nodejs#55312
Fixes: nodejs#55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

events: optimize EventTarget.addEventListener nxtedition/node
2 participants
@ronag @RedYetiDev