Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/types isBigIntObject not documented #55446

Closed
sparecycles opened this issue Oct 18, 2024 · 3 comments · Fixed by #55450
Closed

util/types isBigIntObject not documented #55446

sparecycles opened this issue Oct 18, 2024 · 3 comments · Fixed by #55450
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.

Comments

@sparecycles
Copy link

Affected URL(s)

https://nodejs.org/docs/latest/api/util.html

Description of the problem

Hi!

Small issue: isBigIntObject seems to be present in nodejs (22.9.0) via 'node:util/types', but missing from the documentation and it is also missing in DefinitelyTyped.
@sparecycles sparecycles added the doc Issues and PRs related to the documentations. label Oct 18, 2024
@RedYetiDev
Copy link
Member

PRs are always welcome :-)

@RedYetiDev RedYetiDev added confirmed-bug Issues with confirmed bugs. util Issues and PRs related to the built-in util module. good first issue Issues that are suitable for first-time contributors. labels Oct 18, 2024
leviscar pushed a commit to leviscar/node that referenced this issue Oct 18, 2024
doc: add isBigIntObject to documentation
4e89e62 
Refs: nodejs#55446
@leviscar leviscar mentioned this issue Oct 18, 2024
Merged
@leviscar
Copy link
Contributor

@RedYetiDev I just make a PR for this issue. It's my first PR ^_^

@sparecycles
Copy link
Author

@leviscar thanks for making a PR, I did some research and have one minor correction:

https://github.com/nodejs/node/pull/55450/files#r1807010918

leviscar pushed a commit to leviscar/node that referenced this issue Oct 19, 2024
doc: correct version info for isBigIntObject
e76c16f 
Refs: nodejs#55446
leviscar pushed a commit to leviscar/node that referenced this issue Oct 19, 2024
doc: add isBigIntObject to documentation
9b84cd5 
Fixes: nodejs#55446
leviscar pushed a commit to leviscar/node that referenced this issue Oct 19, 2024
doc: correct version info for isBigIntObject
5bf4ac5 
Fixes: nodejs#55446
aduh95 pushed a commit that referenced this issue Oct 22, 2024
@leviscar
doc: add isBigIntObject to documentation
5983110 
Refs: #19989
Fixes: #55446
PR-URL: #55450
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this issue Oct 23, 2024
@leviscar @aduh95
doc: add isBigIntObject to documentation
689d3a3 
Refs: #19989
Fixes: #55446
PR-URL: #55450
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@leviscar @louwers
doc: add isBigIntObject to documentation
8860600 
Refs: nodejs#19989
Fixes: nodejs#55446
PR-URL: nodejs#55450
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@leviscar @tpoisseau
doc: add isBigIntObject to documentation
fd370cc 
Refs: nodejs#19989
Fixes: nodejs#55446
PR-URL: nodejs#55450
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
@leviscar @ruyadorno
doc: add isBigIntObject to documentation
2030285 
Refs: #19989
Fixes: #55446
PR-URL: #55450
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add isBigIntObject to documentation leviscar/node
3 participants
@sparecycles @leviscar @RedYetiDev