-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing version info about some members of URL
class & URLSearchParams
class
#55806
Comments
URL
classURL
class & URLSearchParams
class
Do you want to submit a PR? |
This comment was marked as outdated.
This comment was marked as outdated.
I'd like to make it later. But if someone else is also eager to make, it is fine. |
Sure, I didn't want to take credit for your research without your approval.
IIUC that's already documented: Lines 107 to 112 in 5a775b3
Good catch, we can also add that it was backported to 6.13.0. I can open a PR for that. EDIT: that's #55818
It also landed on 6.x thanks to #17365, so I think the documentation is correct Lines 711 to 716 in 5a775b3
|
More issues find when working with mdn/browser-compat-data#24997 and mdn/browser-compat-data#24998, some are included in #55840 and others I've fired #55841 for it. |
PR-URL: nodejs#55818 Fixes: nodejs#55806 Refs: nodejs#11236 Refs: nodejs#17365 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Affected URL(s)
https://nodejs.org/docs/latest/api/url.html
Description of the problem
some members of
URL
class &URLSearchParams
class didn't list its version infoURL
class implement is added in v7.0.0 and v6.13.0, via #7448URL.prototype.toJSON()
implement is added in v7.7.0, via #11236URLSearchParams
class implement is added in v7.0.0 and v6.13.0, as an internal instance, via #7448,and exported in v7.5.0 via #10801
The text was updated successfully, but these errors were encountered: