Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: tools: show linting progress / parallelize linting #5596

Closed
mscdex opened this issue Mar 8, 2016 · 3 comments · Fixed by #5638
Closed

feature request: tools: show linting progress / parallelize linting #5596

mscdex opened this issue Mar 8, 2016 · 3 comments · Fixed by #5638
Labels
feature request Issues that request new features to be added to Node.js. tools Issues and PRs related to the tools directory.

Comments

@mscdex
Copy link
Contributor

mscdex commented Mar 8, 2016

  • Version: master
  • Platform: n/a
  • Subsystem: tools

In light of #5595, it would be nice to have some kind of progress output when linting, similar to what we have when running tests.

Additionally, it would be nice to have a -J option to parallelize linting (like the test runner).
@mscdex mscdex added feature request Issues that request new features to be added to Node.js. tools Issues and PRs related to the tools directory. labels Mar 8, 2016
@Trott
Copy link
Member

Trott commented Mar 8, 2016

Potentially relevant: eslint/eslint#1101

@mscdex
Copy link
Contributor Author

mscdex commented Mar 8, 2016

@Trott As far as I can tell, that --verbose would spam the console with every file linted? I was mainly looking for a simple progress indicator that updates in place.

@Trott
Copy link
Member

Trott commented Mar 8, 2016

@mscdex Yup. "Possibly relevant" as in that could evolve into something more like a progress bar, or work done on that would be a precursor to a progress bar. Definitely not a perfect fit for what you're looking for.

@mscdex mscdex mentioned this issue Mar 10, 2016
Merged
4 tasks
@mscdex mscdex changed the title feature request: tool: show linting progress / parallelize linting feature request: tools: show linting progress / parallelize linting Mar 10, 2016
mscdex added a commit to mscdex/io.js that referenced this issue Apr 15, 2016
@mscdex
tools: improve js linter
81fd458 
This commit switches from the eslint command-line tool to a custom
tool that uses eslint programmatically in order to perform linting
in parallel and to display linting results incrementally instead of
buffering them until the end.

Fixes: nodejs#5596
PR-URL: nodejs#5638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@mscdex
tools: improve js linter
b3e62f5 
This commit switches from the eslint command-line tool to a custom
tool that uses eslint programmatically in order to perform linting
in parallel and to display linting results incrementally instead of
buffering them until the end.

Fixes: #5596
PR-URL: #5638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
@mscdex
tools: improve js linter
f201b01 
This commit switches from the eslint command-line tool to a custom
tool that uses eslint programmatically in order to perform linting
in parallel and to display linting results incrementally instead of
buffering them until the end.

Fixes: #5596
PR-URL: #5638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this issue Apr 21, 2016
@mscdex @MylesBorins
tools: improve js linter
713f6ff 
This commit switches from the eslint command-line tool to a custom
tool that uses eslint programmatically in order to perform linting
in parallel and to display linting results incrementally instead of
buffering them until the end.

Fixes: #5596
PR-URL: #5638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
jasnell pushed a commit that referenced this issue Apr 26, 2016
@mscdex @jasnell
tools: improve js linter
396fbeb 
This commit switches from the eslint command-line tool to a custom
tool that uses eslint programmatically in order to perform linting
in parallel and to display linting results incrementally instead of
buffering them until the end.

Fixes: #5596
PR-URL: #5638
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: improve js linter mscdex/io.js
2 participants
@mscdex @Trott