-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation on Windows doesn't "symlink" iojs to node #560
Comments
I think the idea is to have them as individual entities on the machine. |
Yeah, that'd be the point 3 then. But that, as I've wrote, would be inconsistent with what happens on other platforms. In any case, the least installer should do is to tell the user what will happen with his/her installations of node and npm. |
I think it should be consistent too. How about an default-on option in the windows installer to symlink? |
By default the installer creates a hard link. But the installer inserts the iojs directory at the end of the PATH environment variable, so if you already have node installed when you install iojs then iojs' node.exe doesn't "replace" node. |
@piscisaureus Ah, that's one elegant way of solving this. Is the Windows installer code on GitHub? I'd like to have a look. |
@piscisaureus: Thanks! So as a solution for this issue: Should we insert our path at the start of |
Injecting your path at the beginning of |
How about parsing the path for node and inserting before that? Is that possible with MSI? |
That's easy to do, if we want it. I'm in the @dougwilson camp here - it's friendlier to put yourself at the end. But make a good case and I may change my opinion. |
How about this (pseudocode): Run |
I think its better to provide a message to the user about an existing node installation on the path. Modifying path string, other than at the end, doesn't go with the usual windows installation way. |
Providing a message/explanation what's gonna happen would be fine by me. Just to not leave an user in the unknown. |
I would rather have this info in the docs (that you can move it to be first fixing everything and keeping both versions), or in the installer somewhere easy to find. Putting this in front of everything else is not a good practice and as @cosmosgenius said is not the Windows way. I think the ruby installer does this and it causes lots of issues for some. |
See #751 (comment) |
I've just installed io.js v1.0.3 on my machine and it didn't create symlinks to node.
When I now run
node -v
I getv0.10.33
and wheniojs -v
I getv1.0.3
.Now, this might be because:
On a side note, I think installer should provide some info about what's gonna happen with the current node and npm installations.
Some additional info:
The text was updated successfully, but these errors were encountered: