Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undici updates are broken #56061

Closed
mcollina opened this issue Nov 28, 2024 · 1 comment · Fixed by #56069
Closed

Undici updates are broken #56061

mcollina opened this issue Nov 28, 2024 · 1 comment · Fixed by #56069

Comments

@mcollina
Copy link
Member

as titled: https://github.com/nodejs/node/actions/runs/12059440799/job/33628072631

It seems esbuild is now missing.

cc @nodejs/undici
targos added a commit to targos/node that referenced this issue Nov 29, 2024
@targos
tools: fix update-undici script
0bfbd00 
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
@targos targos mentioned this issue Nov 29, 2024
Merged
@targos
Copy link
Member

targos commented Nov 29, 2024

Fix: #56069

targos added a commit that referenced this issue Dec 2, 2024
@targos
tools: fix update-undici script
98ce465 
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: fix update-undici script targos/node
2 participants
@mcollina @targos