Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Namespacing sqlite constants #56193

Closed
Renegade334 opened this issue Dec 9, 2024 · 1 comment · Fixed by #56213
Closed

Proposal: Namespacing sqlite constants #56193

Renegade334 opened this issue Dec 9, 2024 · 1 comment · Fixed by #56213

Comments

@Renegade334
Copy link
Contributor

#54181 added wrappers for session methods, and to that end exports the SQLITE_CHANGESET_* constants to pass through to sqlite3changeset_apply().

These are currently exposed as enumerable top-level properties of the node:sqlite module. By contrast, other modules that export constants do so under their own exported constants namespace (os, vm etc.) to avoid polluting the module scope.

While the sqlite module remains experimental, would it be worth taking the opportunity to sequester these away as sqlite.constants.*?

@Renegade334 Renegade334 changed the title Discussion: Namespacing sqlite constants Proposal: Namespacing sqlite constants Dec 9, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Dec 10, 2024

That sounds like a good idea to me.

nodejs-github-bot pushed a commit that referenced this issue Dec 17, 2024
PR-URL: #56213
Fixes: #56193
Refs: #56193
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this issue Dec 18, 2024
PR-URL: #56213
Fixes: #56193
Refs: #56193
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this issue Dec 18, 2024
PR-URL: #56213
Fixes: #56193
Refs: #56193
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants