-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Namespacing sqlite
constants
#56193
Comments
Renegade334
changed the title
Discussion: Namespacing
Proposal: Namespacing Dec 9, 2024
sqlite
constantssqlite
constants
That sounds like a good idea to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#54181 added wrappers for session methods, and to that end exports the
SQLITE_CHANGESET_*
constants to pass through tosqlite3changeset_apply()
.These are currently exposed as enumerable top-level properties of the
node:sqlite
module. By contrast, other modules that export constants do so under their own exportedconstants
namespace (os, vm etc.) to avoid polluting the module scope.While the sqlite module remains experimental, would it be worth taking the opportunity to sequester these away as
sqlite.constants.*
?The text was updated successfully, but these errors were encountered: