Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit commits not found on v4.x #5647

Closed
MylesBorins opened this issue Mar 10, 2016 · 5 comments
Closed

Audit commits not found on v4.x #5647

MylesBorins opened this issue Mar 10, 2016 · 5 comments

Comments

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 10, 2016

I just did a run of branch diff and will put the results in a comment below. It appears there are 77 patch level commits that have landed on master that are not currently under LTS watch

branch-diff v4.x-staging master --exclude-label semver-major,semver-minor,lts-watch-v4.x,dont-land-on-v4.x --filter-release

edit: back at it again with the white vans

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Mar 10, 2016

  • [2dc5ad460a] - test: move more tests from sequential to parallel (Santiago Gimeno) #6187
  • [f8e507eaf1] - test: add zlib close-after-error regression test (Anna Henningsen) #6270
  • [4faaed69fa] - test,tools: enable linting for undefined vars (Rich Trott) #6255
  • [8ede3d5002] - tools: lint rule for assert.fail() (Rich Trott) #6261
  • [7fc4b31051] - build: fix make tar-headers for Linux (Gibson Fahnestock) #5978
  • [c1d82ac2ff] - assert: respect assert.doesNotThrow message. (Ilya Shaisultanov) #2407
  • [b95160daae] - test: move the debugger tests back to parallel (Santiago Gimeno) #6246
  • [15f13cd74a] - test,vm: enable strict mode for vm tests (Rich Trott) #6209
  • [f49a1d0501] - build: allow test-ci to run tests in parallel (Johan Bergström) #6208
  • [8d1d3bb714] - test: refactor http-end-throw-socket-handling (Santiago Gimeno) #5676
  • [725ffdb9b7] - dgram: handle default address case when offset and length are specified (Matteo Collina)
  • [494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #3375

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Mar 10, 2016

Copying over some of the comments @rvagg had that are still relevant from #4698

  • [494227b] - node: improve GetActiveRequests performance (Trevor Norris) node: improve GetActiveRequests performance #3375 — interesting because it's a great perf improvement, not exposed via public API, but it is heavy-handed and not the API is not widely used so unlikely to be finding edge-cases very quickly. Perhaps it can be on a longer-term watch-list for LTS?

@mscdex mscdex added the v4.x label Mar 10, 2016
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/lts

@MylesBorins
Copy link
Contributor Author

/cc @mhdawson re: 1d65b99

@MylesBorins
Copy link
Contributor Author

closing and opening a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants