-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Closed
Description
Current situation
The version of Visual C++ build tools workload installed by tools/msvs/install_tools/install_tools.bat is not aligned with the version specified in BUILDING > Supported toolchains for Windows:
| Node.js branch | Windows Supported toolchain | install_tools.bat |
|---|---|---|
| v20.x | Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host | visualstudio2019-workload-vctools |
| v22.x | Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host | visualstudio2019-workload-vctools |
| v24.x | Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host | visualstudio2019-workload-vctools |
In all branches, tools/msvs/install_tools/install_tools.bat the following choco command is executed:
choco upgrade -y python visualstudio2019-workload-vctoolsThis is also what gets executed if a user installs Node.js as a Windows MSI package and then selects to install "Tools for Native Modules"
Expected
For Node.js 22.x and 24.x expect that tools/msvs/install_tools/install_tools.bat installs
Visual C++ build tools workload for Visual Studio 2022 (visualstudio2022-workload-vctools)
instead of
Visual C++ build tools workload for Visual Studio 2019 (visualstudio2019-workload-vctools)
Related
- Also mentioned in Remove dependency on Chocolatey #51905 (comment) by @Daverd-GM
- See also BUILDING > Windows
Daverd-GM
Metadata
Metadata
Assignees
Labels
No labels