failed test: parallel/test-tls-no-sslv3.js with shared openssl

[jbergstroem]

Path: parallel/test-tls-no-sslv3
child_process.js:1100
  var err = this._handle.spawn(options);
                         ^
TypeError: Bad argument
    at TypeError (native)
    at ChildProcess.spawn (child_process.js:1100:26)
    at exports.spawn (child_process.js:959:9)
    at Server.<anonymous> (parallel/test-tls-no-sslv3.js:25:16)
    at Server.g (events.js:184:16)
    at Server.emit (events.js:95:17)
    at net.js:1167:12
    at process._tickCallback (node.js:337:11)
    at Function.Module.runMain (module.js:489:11)
    at startup (node.js:111:16)

The problem is that common.opensslCli will return false instead of a path to the openssl-binary, since it hasn't been built. The simple way is just to check for false before running the test, but it feels like a poor decision since we'd probably want to run the test suite with a shared openssl as much as possible (so the user can verify that their setup is correct).

[shigeki]

Fixed in #762

[jbergstroem]

Here's the result from the test after fixing path to openssl binary:

=== release test-tls-no-sslv3 ===                                              
Path: parallel/test-tls-no-sslv3
CONNECTED(00000003)
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : SSLv3
    Cipher    : 0000
    Session-ID: 
    Session-ID-ctx: 
    Master-Key: 
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time: 1423692122
    Timeout   : 7200 (sec)
    Verify return code: 0 (ok)
---
assert.js:87
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at Server.<anonymous> (/home/jbergstroem/iojs/test/parallel/test-tls-no-sslv3.js:38:3)
    at Server.<anonymous> (/home/jbergstroem/iojs/test/common.js:268:15)
    at Server.g (events.js:240:16)
    at emitTwo (events.js:85:13)
    at Server.emit (events.js:153:7)
    at TLSSocket.<anonymous> (_tls_wrap.js:650:14)
    at emitOne (events.js:75:13)
    at TLSSocket.emit (events.js:150:7)
    at TLSSocket._tlsError (_tls_wrap.js:404:8)
    at TLSWrap.ssl.onerror (_tls_wrap.js:315:12)
140550306789008:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:s3_pkt.c:1456:SSL alert number 40
140550306789008:error:1409E0E5:SSL routines:ssl3_write_bytes:ssl handshake failure:s3_pkt.c:644:
Command: out/Release/iojs /home/jbergstroem/iojs/test/parallel/test-tls-no-sslv3.js

[shigeki]

@jbergstroem Thanks for your report. This error comes from the change of an error message in openssl-1.0.2 and it is to be fixed with shigeki@72031e6 after upgrading to openssl-1.0.2 . Please wait for a moment until I finish it.

[jbergstroem]

@shigeki confirmed -- just tried with openssl 1.0.1l. I'm closing since we shouldn't assume 1.0.2 is working until that work is merged.