-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split test/parallel into subsystem folders #6217
Comments
Definite +1 on this, it's getting rather difficult to manage. Not sure if
|
I like it +1 from me |
I've got this working. Just need to fix the relative URLs in tests. PR coming soon. |
What is a main difficulty of managing it? (Note: I'm +0 myself so far, so would appreciate to learn some arguments) |
I don't see the need to change the current directory structure besides accommodating github. Am ±0 on whether this is important enough to warrant changing the entire structure again. except in a way that makes backporting tests more annoying. |
oooo that's a good point @trevnorris. |
Allow running tests in subdirectories of test/parallel. Split up most tests in test/parallel into reasonable subdirectories. Fixes: nodejs#6217
so this also has problems in some test editors, e.g. atom doesn't do awesome with that folder |
This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that. FWIW, the implementation in #6230 got some mixed reactions. |
The
/parallel/
tests directory is pretty huge, with 1010 tests at the time of writing.So large, that GitHub has begun truncating it. And, it is pretty hard to scroll though to find something (depending on your editor of choice).
Perhaps we should split it into actual subsystem folders? Does the test runner allow for that?
It would be a bit of a headache again though, like when we moved
/simple/
to/parallel/
..cc @nodejs/testing & @nodejs/ctc
The text was updated successfully, but these errors were encountered: