Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split test/parallel into subsystem folders #6217

Closed
Fishrock123 opened this issue Apr 15, 2016 · 8 comments
Closed

split test/parallel into subsystem folders #6217

Fishrock123 opened this issue Apr 15, 2016 · 8 comments
Labels
discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.

Comments

@Fishrock123
Copy link
Contributor

The /parallel/ tests directory is pretty huge, with 1010 tests at the time of writing.
So large, that GitHub has begun truncating it. And, it is pretty hard to scroll though to find something (depending on your editor of choice).

screen shot 2016-04-15 at 10 08 02 am

Perhaps we should split it into actual subsystem folders? Does the test runner allow for that?

It would be a bit of a headache again though, like when we moved /simple/ to /parallel/..

cc @nodejs/testing & @nodejs/ctc

@Fishrock123 Fishrock123 added test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. labels Apr 15, 2016
@jasnell
Copy link
Member

jasnell commented Apr 15, 2016

Definite +1 on this, it's getting rather difficult to manage. Not sure if
the test runner supports it but would be easy to test. Definite headache
but worth doing.
On Apr 15, 2016 7:31 AM, "Jeremiah Senkpiel" notifications@github.com
wrote:

The /parallel/ tests directory is pretty huge, with 1010 tests at the
time of writing.
So large, that GitHub has begun truncating it. And, it is pretty hard to
scroll though to find something (depending on your editor of choice).

[image: screen shot 2016-04-15 at 10 08 02 am]
https://cloud.githubusercontent.com/assets/1093990/14564529/f22f91d6-02f4-11e6-9376-8ded16d523be.png

Perhaps we should split it into actual subsystem folders? Does the test
runner allow for that?

It would be a bit of a headache again though, like when we moved /simple/
to /parallel/..

cc @nodejs/testing https://github.com/orgs/nodejs/teams/testing &
@nodejs/ctc https://github.com/orgs/nodejs/teams/ctc


You are receiving this because you are on a team that was mentioned.
Reply to this email directly or view it on GitHub
#6217

@Fishrock123 Fishrock123 added the discuss Issues opened for discussions and feedbacks. label Apr 15, 2016
@evanlucas
Copy link
Contributor

I like it +1 from me

@bengl
Copy link
Member

bengl commented Apr 15, 2016

I've got this working. Just need to fix the relative URLs in tests. PR coming soon.

@indutny
Copy link
Member

indutny commented Apr 15, 2016

What is a main difficulty of managing it? (Note: I'm +0 myself so far, so would appreciate to learn some arguments)

@trevnorris
Copy link
Contributor

I don't see the need to change the current directory structure besides accommodating github. Am ±0 on whether this is important enough to warrant changing the entire structure again. except in a way that makes backporting tests more annoying.

@evanlucas
Copy link
Contributor

oooo that's a good point @trevnorris.

bengl added a commit to bengl/node that referenced this issue Apr 15, 2016
Allow running tests in subdirectories of test/parallel.

Split up most tests in test/parallel into reasonable subdirectories.

Fixes: nodejs#6217
@calvinmetcalf
Copy link
Contributor

so this also has problems in some test editors, e.g. atom doesn't do awesome with that folder

@Trott
Copy link
Member

Trott commented Jul 7, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

FWIW, the implementation in #6230 got some mixed reactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

8 participants