Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform streams: unpipe or ignore future writes after .push(null) #64

Closed
jonathanong opened this issue Dec 4, 2014 · 2 comments · May be fixed by solebox/node#24, UbuntuEvangelist/node#15, erdun/node#39, enterstudio/node#23 or s4sc/node#23
Closed

transform streams: unpipe or ignore future writes after .push(null) #64

jonathanong opened this issue Dec 4, 2014 · 2 comments · May be fixed by solebox/node#24, UbuntuEvangelist/node#15, erdun/node#39, enterstudio/node#23 or s4sc/node#23

Comments

@jonathanong
Copy link
Contributor

nodejs/node-v0.x-archive#6694

/cc @chrisdickinson
@juliangruber
Copy link
Member

👍 , def. looks like a bug to me

@chrisdickinson
Copy link
Contributor

Keeping this discussion in original issue.

kunalspathak referenced this issue in nodejs/node-chakracore Dec 7, 2015
@kunalspathak
Merge pull request #64 from Microsoft/CodeCleanup
5a54c00 
chakrashim: Code cleanup

Reviewed most of the CHAKRA-TODO for error handling and updated the code
accordingly. Removed these comments from the code. 
Minor clean up to undo the @eb3d8ba now Chakra propagates the OOM errors.
Converted keepalive property name to symbols.
@icefapper icefapper mentioned this issue Mar 25, 2016
Closed
@narqo narqo mentioned this issue Aug 18, 2016
Closed
@bradennapier bradennapier mentioned this issue May 4, 2018
Closed
mmarchini pushed a commit that referenced this issue Jun 5, 2018
test: update postmortem metadata test
5305bc4 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jun 7, 2018
@targos
test: update postmortem metadata test
d0af005 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jun 9, 2018
@targos
test: update postmortem metadata test
bbf25bf 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jun 10, 2018
@targos
test: update postmortem metadata test
2dea205 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jun 16, 2018
@targos
test: update postmortem metadata test
2b98153 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jun 19, 2018
@targos
test: update postmortem metadata test
170a537 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 2, 2018
@targos
test: update postmortem metadata test
3d94798 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 13, 2018
@targos
test: update postmortem metadata test
8857c58 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 21, 2018
@targos
test: update postmortem metadata test
8897694 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 23, 2018
@targos
test: update postmortem metadata test
5903c5b 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 24, 2018
@targos
test: update postmortem metadata test
c470efb 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 25, 2018
@targos
test: update postmortem metadata test
f589431 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 25, 2018
@targos
test: update postmortem metadata test
0cff95f 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 26, 2018
@targos
test: update postmortem metadata test
1cd5c84 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Jul 29, 2018
@targos
test: update postmortem metadata test
229291a 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Aug 4, 2018
@targos
test: update postmortem metadata test
8ecf221 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Aug 7, 2018
@targos
test: update postmortem metadata test
007ee78 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
targos pushed a commit that referenced this issue Aug 11, 2018
@targos
test: update postmortem metadata test
f8f4785 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: #64
devsnek pushed a commit to devsnek/node that referenced this issue Aug 15, 2018
@nodejs-ci
test: update postmortem metadata test
c8b6a26 
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

Fixes: nodejs#64
@tufosa tufosa mentioned this issue Sep 3, 2019
Open
@KalebMills KalebMills mentioned this issue Dec 2, 2019
Closed
@joyeecheung joyeecheung mentioned this issue Feb 20, 2020
Closed
@pimterry pimterry mentioned this issue Mar 13, 2020
Closed
@wmertens wmertens mentioned this issue Jun 19, 2020
Closed
@silverwind silverwind mentioned this issue Aug 20, 2020
Closed
@emremrah emremrah mentioned this issue Dec 26, 2020
Closed
@djulien djulien mentioned this issue Jan 13, 2021
Open
targos added a commit to targos/node that referenced this issue Apr 17, 2021
@targos
deps: V8: cherry-pick 53c4d057974a
4095157 
Original commit message:

    Reland "[regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition"

    This is a reland of 164cf80bbb0a6e091300bfc4cbbe70a6e6bd3e49

    The reland fixes UB (left-shift of negative integer type) with a
    static_cast<uint32_t>.

    Original change's description:
    > [regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition
    >
    > Drive-by: Range checks in `Emit(byte, twenty_four_bits)` to ensure the
    > given packed bits actually fit into 24 bits.
    >
    > Bug: chromium:1166138
    > Change-Id: I2e711e6466bb48d7b9897f68dfe621d12bd92508
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625877
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72064}

    (cherry picked from commit ff8d0f92d423774cf773b5b4fb48b6744971e27a)

    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Tbr: leszeks@chromium.org
    Bug: chromium:1166138
    Change-Id: I514495e14bb99dfc9588fdb4a9f35d67d8d64acb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626663
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#72088}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742954
    Reviewed-by: Jana Grill <janagrill@chromium.org>
    Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#64}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@53c4d05
targos added a commit to targos/node that referenced this issue Apr 27, 2021
@targos
deps: V8: cherry-pick 53c4d057974a
6506918 
Original commit message:

    Reland "[regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition"

    This is a reland of 164cf80bbb0a6e091300bfc4cbbe70a6e6bd3e49

    The reland fixes UB (left-shift of negative integer type) with a
    static_cast<uint32_t>.

    Original change's description:
    > [regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition
    >
    > Drive-by: Range checks in `Emit(byte, twenty_four_bits)` to ensure the
    > given packed bits actually fit into 24 bits.
    >
    > Bug: chromium:1166138
    > Change-Id: I2e711e6466bb48d7b9897f68dfe621d12bd92508
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625877
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72064}

    (cherry picked from commit ff8d0f92d423774cf773b5b4fb48b6744971e27a)

    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Tbr: leszeks@chromium.org
    Bug: chromium:1166138
    Change-Id: I514495e14bb99dfc9588fdb4a9f35d67d8d64acb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626663
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#72088}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742954
    Reviewed-by: Jana Grill <janagrill@chromium.org>
    Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#64}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@53c4d05
targos added a commit that referenced this issue Apr 30, 2021
@targos
deps: V8: cherry-pick 53c4d057974a
26cc160 
Original commit message:

    Reland "[regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition"

    This is a reland of 164cf80bbb0a6e091300bfc4cbbe70a6e6bd3e49

    The reland fixes UB (left-shift of negative integer type) with a
    static_cast<uint32_t>.

    Original change's description:
    > [regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition
    >
    > Drive-by: Range checks in `Emit(byte, twenty_four_bits)` to ensure the
    > given packed bits actually fit into 24 bits.
    >
    > Bug: chromium:1166138
    > Change-Id: I2e711e6466bb48d7b9897f68dfe621d12bd92508
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625877
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72064}

    (cherry picked from commit ff8d0f92d423774cf773b5b4fb48b6744971e27a)

    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Tbr: leszeks@chromium.org
    Bug: chromium:1166138
    Change-Id: I514495e14bb99dfc9588fdb4a9f35d67d8d64acb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626663
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#72088}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742954
    Reviewed-by: Jana Grill <janagrill@chromium.org>
    Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
    Cr-Commit-Position: refs/branch-heads/8.6@{#64}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@53c4d05

PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This was referenced Jul 17, 2021
Open
Closed
This was referenced Sep 13, 2021
Open
Open
Open
Open
Open
@mscdex mscdex mentioned this issue Oct 11, 2021
Closed
@solebox solebox mentioned this issue May 13, 2022
Open
@enterstudio enterstudio mentioned this issue May 14, 2022
Open
@UbuntuEvangelist UbuntuEvangelist mentioned this issue May 14, 2022
Open
@s4sc s4sc mentioned this issue May 14, 2022
Open
@cyco130 cyco130 mentioned this issue Jan 15, 2023
Open
@nodated nodated mentioned this issue Jan 25, 2023
Closed
@dunhor dunhor mentioned this issue Jan 26, 2023
Closed
@thetazero thetazero mentioned this issue Feb 9, 2023
Closed
@ArchanaWind ArchanaWind mentioned this issue Feb 14, 2023
Closed
This was referenced May 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@juliangruber @chrisdickinson @jonathanong