Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit support to repl #6457

Closed
tracker1 opened this issue Apr 29, 2016 · 4 comments
Closed

Add exit support to repl #6457

tracker1 opened this issue Apr 29, 2016 · 4 comments
Labels
question Issues that look for answers. repl Issues and PRs related to the REPL subsystem.

Comments

@tracker1
Copy link

Just a nice to have feature request. It would be nice, if one could simply type exit and enter into the repl, and have it process.exit(0)

This would match up with most command-line interface repls, from bash to cmd, etc... and is second nature to type in. I'm not sure if this has been debated, as I didn't see an issue regarding this. As it stands, I can type exit\n faster than I can press ctrl+c twice.

Hopefully this feature is doable, and others can agree on the usefulness.

Alternatively to an immediate process.exit(0) would be process.nextTick(() => process.exit(0)) so that pending outputs can finish out.
@addaleax
Copy link
Member

.exit does what you want, I think.

@addaleax addaleax added question Issues that look for answers. repl Issues and PRs related to the REPL subsystem. labels Apr 29, 2016
@evanlucas
Copy link
Contributor

Or use Ctrl+d

@mscdex
Copy link
Contributor

mscdex commented Apr 29, 2016 •
edited
Loading

As noted, there are existing solutions to this. Simply supporting exit would not work because that would mean reserving that keyword which is not really ideal (and .exit has existed for a long time and it is only one more character).

@jasnell
Copy link
Member

jasnell commented Apr 29, 2016

Closing!

@jasnell jasnell closed this as completed Apr 29, 2016
rvagg added a commit to rvagg/io.js that referenced this issue Jun 15, 2018
@rvagg
deps: float 3984ef0 from openssl / CVE-2018-0732
bb82a62 
Pending OpenSSL 1.0.2p release.

Ref: nodejs#21282
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Upstream: openssl/openssl@3984ef0

Original commit message:
    Reject excessively large primes in DH key generation.

    CVE-2018-0732

    Signed-off-by: Guido Vranken <guidovranken@gmail.com>

    (cherry picked from commit 91f7361)

    Reviewed-by: Tim Hudson <tjh@openssl.org>
    Reviewed-by: Matt Caswell <matt@openssl.org>
    (Merged from nodejs#6457)
rvagg added a commit that referenced this issue Jun 18, 2018
@rvagg
deps: float 3984ef0 from openssl / CVE-2018-0732
31a571d 
Pending OpenSSL 1.0.2p release.

Ref: #21282
Upstream: openssl/openssl@3984ef0
Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message:
    Reject excessively large primes in DH key generation.

    CVE-2018-0732

    Signed-off-by: Guido Vranken <guidovranken@gmail.com>

    (cherry picked from commit 91f7361)

    Reviewed-by: Tim Hudson <tjh@openssl.org>
    Reviewed-by: Matt Caswell <matt@openssl.org>
    (Merged from #6457)
rvagg added a commit that referenced this issue Jun 18, 2018
@rvagg
deps: float 3984ef0 from openssl / CVE-2018-0732
5a30e0b 
Pending OpenSSL 1.0.2p release.

Ref: #21282
Upstream: openssl/openssl@3984ef0
Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message:
    Reject excessively large primes in DH key generation.

    CVE-2018-0732

    Signed-off-by: Guido Vranken <guidovranken@gmail.com>

    (cherry picked from commit 91f7361)

    Reviewed-by: Tim Hudson <tjh@openssl.org>
    Reviewed-by: Matt Caswell <matt@openssl.org>
    (Merged from #6457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Issues that look for answers. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mscdex @jasnell @tracker1 @evanlucas @addaleax