Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failures in test-process-exec-argv #6480

Closed
mhdawson opened this issue Apr 29, 2016 · 5 comments
Closed

Intermittent failures in test-process-exec-argv #6480

mhdawson opened this issue Apr 29, 2016 · 5 comments
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

  • Version: 6.0 (built from source)
  • Platform: Seen on s390 but believe could occur on any
  • Subsystem: process

We see this test fail intermittently (about 0.4% of the time on one of our machines) with:

680 - test-process-exec-argv.js
not ok 680 test-process-exec-argv.js
# undefined:1
#
#
#
# SyntaxError: Unexpected end of JSON input
# at Object.parse (native)
# at ChildProcess. (/build/jenkins/new/workspace/ibmnode-v6-test-linux/ARCH/s390/DISTRO/rhel7/GCC/gcc48/OS/linux/SUITE/node/labels/bvt/node/test/parallel/test-process-exec-argv.js:19:33)
# at emitTwo (events.js:106:13)
# at ChildProcess.emit (events.js:191:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

We believe the cause is related to the issue being discussed here: #6456

Opening this issue as the outcome of #6456 may or may not resolve the failing test depending on what's decided as the right way forward so we need to track this failure to make sure the test is either fixed by what we do for 6456 or that the test is updated to remove the dependency on the process exit timing if what we do for 6456 does not resolve the issue
@addaleax addaleax added test Issues and PRs related to the tests. process Issues and PRs related to the process subsystem. labels Apr 29, 2016
@santigimeno santigimeno mentioned this issue May 4, 2016
Closed
2 tasks
@santigimeno
Copy link
Member

I could reproduce the issue in OS X. This PR: #6575 fixes the issue for me.

@santigimeno
Copy link
Member

@mhdawson can you check if the fix in #6575 fixes the issue for you? Thanks!

@mhdawson
Copy link
Member Author

mhdawson commented May 9, 2016

will do

@mhdawson
Copy link
Member Author

Running in a long loop on the machine we saw the failure as we speak. So far looks good but want to let it run through at least several thousand iterations before comfirming

@mhdawson
Copy link
Member Author

Ok 6000+ runs without a failure with that patch so looks good.

santigimeno added a commit to santigimeno/node that referenced this issue May 12, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
80481da 
Wait for the `close` event before parsing the child stdout output.

Fixes: nodejs#6480
PR-URL: nodejs#6575
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@santigimeno santigimeno mentioned this issue May 12, 2016
Closed
evanlucas pushed a commit that referenced this issue May 17, 2016
@santigimeno @evanlucas
test: fix test-process-exec-argv flakiness
89b25fa 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
PR-URL: #6575
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
santigimeno added a commit to santigimeno/node that referenced this issue Jun 3, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
8d1d780 
Wait for the `close` event before parsing the child stdout output.

Fixes: nodejs#6480
Ref: nodejs#6575
PR-URL: nodejs#7128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Jun 4, 2016
@santigimeno @MylesBorins
test: fix test-process-exec-argv flakiness
8f55108 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
ab50e82 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
b4b5c54 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-process-exec-argv flakiness santigimeno/node
3 participants
@addaleax @santigimeno @mhdawson