Investigate flaky test-net-GH-5504

[Trott]

Failure:

• fedora21

[santigimeno]

I include the error, just in case the link is gone:

not ok 1113 test-net-GH-5504.js
# SERVER 2>NET 14244: listen2 null 12346 4 false undefined
# SERVER 2>NET 14244: _listen2: create a handle
# SERVER 2>NET 14244: bind to ::
# CLIENT 2>NET 14249: createConnection [ { host: 'localhost', port: 12346 }, [Function] ]
# CLIENT 2>NET 14249: pipe false undefined
# CLIENT 2>NET 14249: connect: find host localhost
# CLIENT 2>NET 14249: connect: dns options { family: undefined, hints: 32 }
# CLIENT 2>NET 14249: afterConnect
# CLIENT 2>NET 14249: destroy undefined
# CLIENT 2>NET 14249: destroy
# CLIENT 2>NET 14249: close
# CLIENT 2>NET 14249: close handle
# CLIENT 2>NET 14249: _read
# CLIENT 2>NET 14249: _read wait for connection
# CLIENT 2>NET 14249: emit close
# SERVER 2>NET 14244: onconnection
# SERVER 2>NET 14244: _read
# SERVER 2>NET 14244: Socket._read readStart
# SERVER 2>NET 14244: SERVER _emitCloseIfDrained
# SERVER 2>NET 14244: SERVER handle? false   connections? 1
# SERVER 2>NET 14244: afterWrite -32
# SERVER 2>NET 14244: write failure { Error: write EPIPE
# SERVER 2>    at exports._errnoException (util.js:949:11)
# SERVER 2>    at WriteWrap.afterWrite (net.js:793:14) code: 'EPIPE', errno: 'EPIPE', syscall: 'write' }
# SERVER 2>NET 14244: destroy
# SERVER 2>NET 14244: close
# SERVER 2>NET 14244: close handle
# SERVER 2>events.js:160
# SERVER 2>      throw er; // Unhandled 'error' event
# SERVER 2>      ^
# SERVER 2>
# SERVER 2>Error: write EPIPE
# SERVER 2>    at exports._errnoException (util.js:949:11)
# SERVER 2>    at WriteWrap.afterWrite (net.js:793:14)
# server exited 1
# client exited 0
# /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora21/test/sequential/test-net-GH-5504.js:66
# throw new Error('hang');
# ^
# 
# Error: hang
# at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora21/test/sequential/test-net-GH-5504.js:66:13)
# at tryOnTimeout (timers.js:224:11)
# at Timer.listOnTimeout (timers.js:198:5)
# SERVER 1>listening
# ok

[Trott]

Failed on win10 today too: https://ci.nodejs.org/job/node-test-binary-windows/2198/RUN_SUBSET=2,VS_VERSION=vcbt2015,label=win10/tapTestReport/test.tap-282/

not ok 282 c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504
# SERVER 2>NET 3288: listen2 null 12346 4 false undefined
# SERVER 2>NET 3288: _listen2: create a handle
# SERVER 2>NET 3288: bind to ::
# C:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504.js:66
# throw new Error('hang');
# ^
# 
# Error: hang
# at Timeout._onTimeout (C:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504.js:66:13)
# at tryOnTimeout (timers.js:224:11)
# at Timer.listOnTimeout (timers.js:198:5)
# SERVER 1>listening

[Trott]

Another on win10: https://ci.nodejs.org/job/node-test-binary-windows/2211/RUN_SUBSET=2,VS_VERSION=vcbt2015,label=win10/console

not ok 282 c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504
# SERVER 2>NET 4152: listen2 null 12346 4 false undefined
# SERVER 2>NET 4152: _listen2: create a handle
# SERVER 2>NET 4152: bind to ::
# CLIENT 2>NET 1620: createConnection [ { host: 'localhost', port: 12346 }, [Function] ]
# CLIENT 2>NET 1620: pipe false undefined
# CLIENT 2>NET 1620: connect: find host localhost
# CLIENT 2>NET 1620: connect: dns options { family: undefined, hints: 1024 }
# SERVER 2>NET 4152: onconnection
# SERVER 2>NET 4152: _read
# SERVER 2>NET 4152: Socket._read readStart
# SERVER 2>NET 4152: SERVER _emitCloseIfDrained
# SERVER 2>NET 4152: SERVER handle? false   connections? 1
# C:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504.js:66
#       throw new Error('hang');
#       ^
# 
# Error: hang
#     at Timeout._onTimeout (C:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\sequential\test-net-GH-5504.js:66:13)
#     at tryOnTimeout (timers.js:224:11)
#     at Timer.listOnTimeout (timers.js:198:5)
# SERVER 1>listening
  ---
  duration_ms: 3.224

[Trott]

Stress test on everything to see where this is reproducible and still an issue: https://ci.nodejs.org/job/node-stress-single-test/772/

[Trott]

Flaky on win2008r2-1p:

1234   OK: 1234   NOT OK: 0   TOTAL: 9999
1..1
not ok 1 sequential/test-net-GH-5504
# SERVER 2>NET 2664: listen2 null 12346 4 false undefined
# SERVER 2>NET 2664: _listen2: create a handle
# SERVER 2>NET 2664: bind to ::
# CLIENT 2>NET 2036: createConnection [ { host: 'localhost', port: 12346 }, [Function] ]
# CLIENT 2>NET 2036: pipe false undefined
# CLIENT 2>NET 2036: connect: find host localhost
# CLIENT 2>NET 2036: connect: dns options { family: undefined, hints: 1024 }
# C:\workspace\node-stress-single-test\nodes\win2008r2-1p\test\sequential\test-net-GH-5504.js:66
#       throw new Error('hang');
#       ^
# 
# Error: hang
#     at Timeout._onTimeout (C:\workspace\node-stress-single-test\nodes\win2008r2-1p\test\sequential\test-net-GH-5504.js:66:13)
#     at tryOnTimeout (timers.js:224:11)
#     at Timer.listOnTimeout (timers.js:198:5)
# SERVER 1>listening
  ---
  duration_ms: 3.204

[bnoordhuis]

Possibly a transient DNS issue. win2008r2-1p stress test with bnoordhuis/io.js@284e2dc applied:
https://ci.nodejs.org/job/node-stress-single-test/781/

[Trott]

LGTM.