Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js documentation is not print-friendly #6743

Closed
sorcamarian opened this issue May 13, 2016 · 8 comments
Closed

Node.js documentation is not print-friendly #6743

sorcamarian opened this issue May 13, 2016 · 8 comments
Assignees
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js.

Comments

@sorcamarian
Copy link

sorcamarian commented May 13, 2016

Can not print Node.js documentation from: https://nodejs.org/api/all.html .

Some CSS rules are not appropriate for print mode.
Before:
image

Fortunately, I found an simple solution(below).

At the bottom of style.css add this CSS rule:

@media print {

  html  {
    height : auto;
  }

 #column2.interior {
   display : none;
 }

 #column1.interior {
   margin-left : auto;
   overflow-y  :  auto;
 }

}

After my CSS codes:
image

@mscdex mscdex added doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. labels May 13, 2016
@mscdex
Copy link
Contributor

mscdex commented May 13, 2016

/cc @nodejs/documentation

@MylesBorins
Copy link
Contributor

@sorcamarian I was unaware of @ media print.. that is nifty.

Would you be open to sending a pull request with your changes? If you have never done so before I'd be more than happy to help you figure out how to do it!

@sorcamarian
Copy link
Author

@thefourtheye
Yes, I would like to send a pull request.
Please tell me how and where to send the request.

Thanks

@MylesBorins
Copy link
Contributor

MylesBorins commented May 13, 2016

@sorcamarian I believe if you clone the repo you should be able to add your style to this file --> https://github.com/nodejs/node/blob/master/doc/api_assets/style.css

it will be found in the cloned repo at doc/api_assets/style.css

After you have committed your changes you will be able to use the github API to send the PR

You can find more details about how to clone the repo and what not in our contributing guide. Please feel free to ping me here, on twitter via dm, or on irc if you have issues. You could likely even use the github website to edit that file in place and make a pull request.

Once you have the PR in we can do a review and help you get the commit to a point where we can merge it!

@MylesBorins MylesBorins self-assigned this May 13, 2016
@sorcamarian
Copy link
Author

@thealphanerd
I sent the commit.

Thank you!

@MylesBorins
Copy link
Contributor

@sorcamarian I'm not seeing the pull request.. can you share the link to it with me?

@sorcamarian
Copy link
Author

I think I succeeded: #6748

@sorcamarian
Copy link
Author

Please check if the commit is ok.
https://github.com/nodejs/node/pull/6748/commits

Thanks.

santigimeno pushed a commit to santigimeno/node that referenced this issue May 23, 2016
Fixes: nodejs#6743

PR-URL: nodejs#6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fishrock123 pushed a commit that referenced this issue May 23, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg pushed a commit that referenced this issue Jun 2, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 3, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants