Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--inspect message wraps poorly in default terminal sizes. #7067

Closed
Fishrock123 opened this issue May 30, 2016 · 1 comment
Closed

--inspect message wraps poorly in default terminal sizes. #7067

Fishrock123 opened this issue May 30, 2016 · 1 comment
Labels
good first issue Issues that are suitable for first-time contributors. inspector Issues and PRs related to the V8 inspector protocol

Comments

@Fishrock123
Copy link
Contributor 

Jeremiah@Jeremiahs-MacBook-Pro ~/D/node> 
node --inspect ../here-be-dragons/hello-world.js
Debugger listening on port 5858. To start debugging, open the following URL in C
hrome:

...

I'm sure this is an easy fix. My terminal is 80 columns by default, as I'm sure may other peoples' are.
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label May 30, 2016
@Fishrock123 Fishrock123 changed the title --inspector message wraps poorly in regular terminal sizes. --inspector message wraps poorly in default terminal sizes. May 30, 2016
@nicolasromer
Copy link
Contributor

I'm taking a crack at it.

@Fishrock123 Fishrock123 changed the title --inspector message wraps poorly in default terminal sizes. --inspect message wraps poorly in default terminal sizes. May 30, 2016
@addaleax addaleax mentioned this issue May 30, 2016
Closed
1 task
nicolasromer added a commit to nicolasromer/node that referenced this issue May 30, 2016
@nicolasromer
src: add linebreak to inspector message
79e073e 
to prevent ugly line break in 80 column(default) terminal windows

Fixes: nodejs#7067
@mscdex mscdex added inspector Issues and PRs related to the V8 inspector protocol and removed debugger labels Jun 3, 2016
Fishrock123 pushed a commit that referenced this issue Jul 5, 2016
@nicolasromer @Fishrock123
src: add linebreak to inspector message
643b33b 
Add linebreak to inspector ready message to wrap properly in
80 column (default) terminal windows.

Fixes: #7067
PR-URL: #7070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @Fishrock123 @nicolasromer