Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About the cluster.setupMaster can only be called once #7156

Closed
jpuncle opened this issue Jun 5, 2016 · 4 comments
Closed

About the cluster.setupMaster can only be called once #7156

jpuncle opened this issue Jun 5, 2016 · 4 comments
Labels
cluster Issues and PRs related to the cluster subsystem. question Issues that look for answers.

Comments

@jpuncle
Copy link

jpuncle commented Jun 5, 2016

Hi, I see the following statement at the api doc
https://nodejs.org/api/cluster.html#cluster_cluster_settings

It is effectively frozen after being set, because .setupMaster() can only be called once.

but, I couldn't find any limit in the source codes for 'called once'.

Could anyone help me? thanks.
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. question Issues that look for answers. labels Jun 5, 2016
@bnoordhuis
Copy link
Member

I couldn't find any limit

Language barrier? I'm not sure what limit you're referring to.

@jpuncle
Copy link
Author

jpuncle commented Jun 5, 2016

@bnoordhuis I found I could call .setupMaster() any times, not 'called once' that in the api docs

@cjihrig
Copy link
Contributor

cjihrig commented Jun 5, 2016

I think the issue is that the docs say cluster.settings is effectively frozen after a single call because ".setupMaster() can only be called once." However, cluster.settings is updated on every call to setupMaster().

@jpuncle
Copy link
Author

jpuncle commented Jun 5, 2016

@cjihrig Yes, yes, I meaned it.
Sorry, my english is bad.

@cjihrig cjihrig mentioned this issue Jun 6, 2016
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Jun 8, 2016
@cjihrig
doc: remove cluster.setupMaster() myth
779091f 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: nodejs#7156
PR-URL: nodejs#7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
evanlucas pushed a commit that referenced this issue Jun 16, 2016
@cjihrig @evanlucas
doc: remove cluster.setupMaster() myth
0fc8012 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Jul 11, 2016
@cjihrig
doc: remove cluster.setupMaster() myth
a906ef7 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@cjihrig @MylesBorins
doc: remove cluster.setupMaster() myth
a3e7486 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@cjihrig
doc: remove cluster.setupMaster() myth
66309d1 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@cjihrig
doc: remove cluster.setupMaster() myth
075cbac 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@cjihrig
doc: remove cluster.setupMaster() myth
629a76f 
cluster.setupMaster() can be called more than once. Core even has
tests for this functionality. This commit removes an incorrect
statement to the contrary from the documentation.

Fixes: #7156
PR-URL: #7179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @jpuncle @cjihrig